From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Mingjin Ye" <mingjinx.ye@intel.com>, <dev@dpdk.org>
Cc: <qiming.yang@intel.com>, "Yuying Zhang" <Yuying.Zhang@intel.com>,
"Beilei Xing" <beilei.xing@intel.com>
Subject: RE: [PATCH] net/i40e: add diagnostic support in TX path
Date: Fri, 22 Dec 2023 17:17:47 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F0F5@smartserver.smartshare.dk> (raw)
In-Reply-To: <20231221101336.2815928-1-mingjinx.ye@intel.com>
> From: Mingjin Ye [mailto:mingjinx.ye@intel.com]
> Sent: Thursday, 21 December 2023 11.14
>
> The only way to enable diagnostics for TX paths is to modify the
> application source code. Making it difficult to diagnose faults.
>
> In this patch, the devarg option "mbuf_check" is introduced and the
> parameters are configured to enable the corresponding diagnostics.
Why not use the already existing RTE_LIBRTE_MBUF_DEBUG?
>
> supported cases: mbuf, size, segment, offload, strict.
> 1. mbuf: check for corrupted mbuf.
> 2. size: check min/max packet length according to hw spec.
> 3. segment: check number of mbuf segments not exceed hw limitation.
> 4. offload: check any unsupported offload flag.
> 5. strict: check protocol headers.
These are all good things to test for, when debugging.
The checks should be part of RTE_LIBRTE_MBUF_DEBUG, instead of introducing yet another runtime parameter.
Also, it would be better to add these checks somewhere in the ethdev library instead of in the individual drivers. That would make them available for all drivers.
>
> parameter format: mbuf_check=[mbuf,<case1>,<case2>]
> eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=[mbuf,size] -- -i
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
next prev parent reply other threads:[~2023-12-22 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:13 Mingjin Ye
2023-12-22 16:17 ` Morten Brørup [this message]
2024-01-04 10:20 ` [PATCH v3] " Mingjin Ye
2024-01-05 9:59 ` [PATCH v4] " Mingjin Ye
2024-03-01 9:44 ` [PATCH v5] " Mingjin Ye
2024-03-01 10:24 ` Bruce Richardson
2024-03-01 16:13 ` Patrick Robb
2024-03-04 9:33 ` [PATCH v6] net/i40e: add diagnostic support in Tx path Mingjin Ye
2024-03-04 11:47 ` Bruce Richardson
2024-03-05 10:17 ` [PATCH v7] " Mingjin Ye
2024-03-05 12:59 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F0F5@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Yuying.Zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=mingjinx.ye@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).