From: "Morten Brørup" <mb@smartsharesystems.com>
To: <thomas@monjalon.net>, <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: RE: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert
Date: Fri, 16 Feb 2024 08:48:31 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F221@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240216003345.GA24519@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Friday, 16 February 2024 01.34
>
> ping
>
> i'd like to see this change go in asap since it is pre-requisite to
> turning on -Wvla which explicitly caught use of non-constant
> expressions
> in the RTE_BUILD_BUG_ON() hiding bugs.
>
> thanks!
>
> On Mon, Nov 13, 2023 at 09:06:05AM -0800, Stephen Hemminger wrote:
> > Both Gcc, clang and MSVC have better way to do compile time
> > assertions rather than using out of bounds array access.
> > The old method would fail if -Wvla is enabled because compiler
> > can't determine size in that code. Also, the use of new
> > _Static_assert will catch broken code that is passing non-constant
> > expression to RTE_BUILD_BUG_ON().
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> > lib/eal/include/rte_common.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/eal/include/rte_common.h
> b/lib/eal/include/rte_common.h
> > index c1ba32d00e47..bea7c0e57d5e 100644
> > --- a/lib/eal/include/rte_common.h
> > +++ b/lib/eal/include/rte_common.h
> > @@ -16,6 +16,7 @@
> > extern "C" {
> > #endif
> >
> > +#include <assert.h>
> > #include <stdint.h>
> > #include <limits.h>
> >
> > @@ -495,7 +496,7 @@ rte_is_aligned(const void * const __rte_restrict
> ptr, const unsigned int align)
> > /**
> > * Triggers an error at compilation time if the condition is true.
> > */
> > -#define RTE_BUILD_BUG_ON(condition) ((void)sizeof(char[1 -
> 2*!!(condition)]))
> > +#define RTE_BUILD_BUG_ON(condition) static_assert(!(condition),
> #condition)
> >
> > /*********** Cache line related macros ********/
> >
> > --
> > 2.39.2
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-02-16 7:48 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 17:21 [RFC] eal: use _Static_assert() for RTE_BUILD_BUG_ON Stephen Hemminger
2023-11-11 17:52 ` Morten Brørup
2023-11-13 16:30 ` Tyler Retzlaff
2023-11-13 16:28 ` Tyler Retzlaff
2023-11-13 17:06 ` [PATCH v2 0/3] use static_assertion for build errors Stephen Hemminger
2023-11-13 17:06 ` [PATCH v2 1/3] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2023-11-13 17:10 ` Bruce Richardson
2023-11-13 17:54 ` Tyler Retzlaff
2023-11-13 17:06 ` [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON() Stephen Hemminger
2023-11-13 17:55 ` Tyler Retzlaff
2023-11-13 22:13 ` Stephen Hemminger
2023-11-13 22:28 ` Tyler Retzlaff
2023-11-14 0:00 ` Stephen Hemminger
2023-11-14 0:16 ` Stephen Hemminger
2023-11-14 0:22 ` Stephen Hemminger
2023-11-14 5:50 ` Morten Brørup
2023-11-13 17:06 ` [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2023-11-13 17:12 ` Bruce Richardson
2023-11-13 17:57 ` Tyler Retzlaff
2024-02-16 0:33 ` Tyler Retzlaff
2024-02-16 7:48 ` Morten Brørup [this message]
2024-02-16 8:02 ` David Marchand
2024-02-16 20:30 ` Tyler Retzlaff
2023-11-13 18:13 ` [PATCH v2 0/3] use static_assertion for build errors Ferruh Yigit
2023-11-13 18:28 ` Morten Brørup
2023-11-13 18:57 ` Tyler Retzlaff
2023-11-17 16:18 ` [PATCH v3 00/10] replace uses of zero length array Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 02/10] cryptodev: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 03/10] security: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 04/10] pipeline: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 05/10] net/nfp: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 06/10] net/enic: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 07/10] net/mlx5: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 08/10] pdcp: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 09/10] net/cpfl: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 10/10] common/dpaxx: remove zero length array Stephen Hemminger
2024-01-16 18:41 ` [PATCH v3 0/5] use static_assert to catch build errors Stephen Hemminger
2024-01-16 18:41 ` [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2024-01-17 7:58 ` Andrew Rybchenko
2024-01-17 9:26 ` Bruce Richardson
2024-01-17 9:57 ` Morten Brørup
2024-01-16 18:41 ` [PATCH v3 2/5] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Stephen Hemminger
2024-01-17 7:57 ` Andrew Rybchenko
2024-01-16 18:41 ` [PATCH v3 3/5] net/i40e: avoid using const variable in assertion Stephen Hemminger
2024-01-16 18:41 ` [PATCH v3 4/5] mempool: avoid floating point expression in static assertion Stephen Hemminger
2024-01-17 8:06 ` Andrew Rybchenko
2024-01-16 18:41 ` [PATCH v3 5/5] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2024-01-17 7:52 ` Andrew Rybchenko
2024-01-17 17:12 ` Stephen Hemminger
2024-01-17 7:53 ` Mattias Rönnblom
2024-01-17 17:11 ` Stephen Hemminger
2024-01-17 18:19 ` [PATCH v4 0/6] use static assert to cathc build errors Stephen Hemminger
2024-01-17 18:19 ` [PATCH v4 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros Stephen Hemminger
2024-01-18 9:35 ` Konstantin Ananyev
2024-01-18 9:44 ` Andrew Rybchenko
2024-01-19 20:58 ` Tyler Retzlaff
2024-01-19 22:39 ` Stephen Hemminger
2024-01-17 18:19 ` [PATCH v4 2/6] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2024-01-18 9:43 ` Andrew Rybchenko
2024-01-17 18:19 ` [PATCH v4 3/6] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Stephen Hemminger
2024-01-18 9:40 ` Andrew Rybchenko
2024-01-17 18:19 ` [PATCH v4 4/6] net/i40e: avoid using const variable in assertion Stephen Hemminger
2024-01-18 8:57 ` Bruce Richardson
2024-01-18 9:34 ` Konstantin Ananyev
2024-01-17 18:19 ` [PATCH v4 5/6] mempool: avoid floating point expression in static assertion Stephen Hemminger
2024-01-17 18:32 ` Morten Brørup
2024-01-18 9:41 ` Andrew Rybchenko
2024-01-18 9:32 ` Konstantin Ananyev
2024-01-17 18:20 ` [PATCH v4 6/6] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 0/6] use static_assert for build error reports Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros Stephen Hemminger
2024-01-19 1:30 ` fengchengwen
2024-01-18 16:50 ` [PATCH v5 2/6] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 3/6] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 4/6] net/i40e: avoid using const variable in assertion Stephen Hemminger
2024-01-18 16:51 ` [PATCH v5 5/6] mempool: avoid floating point expression in static assertion Stephen Hemminger
2024-01-18 18:46 ` Morten Brørup
2024-01-19 10:07 ` Slava Ovsiienko
2024-01-18 16:51 ` [PATCH v5 6/6] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2024-01-18 18:42 ` Morten Brørup
2024-01-19 13:10 ` Ferruh Yigit
2024-02-16 9:14 ` [PATCH v5 0/6] use static_assert for build error reports David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F221@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).