From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Andrew Boyer" <andrew.boyer@amd.com>, <dev@dpdk.org>
Cc: "Akhil Goyal" <gakhil@marvell.com>
Subject: RE: [PATCH v2] cryptodev: speed up ops pool create
Date: Fri, 16 Feb 2024 18:18:28 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F227@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240216170334.55210-1-andrew.boyer@amd.com>
> From: Andrew Boyer [mailto:andrew.boyer@amd.com]
> Sent: Friday, 16 February 2024 18.04
>
> Use rte_mempool_virt2iova(), which uses arithmetic based on the mempool
> state, rather than rte_mem_virt2iova(), which uses syscalls to look at
> the proc filesystem. This speeds up pool create by more than 90%.
>
> Signed-off-by: Andrew Boyer <andrew.boyer@amd.com>
> ---
> lib/cryptodev/rte_cryptodev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/cryptodev/rte_cryptodev.c
> b/lib/cryptodev/rte_cryptodev.c
> index b233c0ecd7..886eb7adc4 100644
> --- a/lib/cryptodev/rte_cryptodev.c
> +++ b/lib/cryptodev/rte_cryptodev.c
> @@ -2573,7 +2573,7 @@ rte_crypto_op_init(struct rte_mempool *mempool,
>
> __rte_crypto_op_reset(op, type);
>
> - op->phys_addr = rte_mem_virt2iova(_op_data);
> + op->phys_addr = rte_mempool_virt2iova(_op_data);
> op->mempool = mempool;
> }
>
> --
> 2.17.1
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-02-16 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 16:41 [PATCH] cryptodev: add a simple mapping cache to " Andrew Boyer
2024-02-06 14:24 ` [EXT] " Akhil Goyal
2024-02-07 2:24 ` Morten Brørup
2024-02-07 3:02 ` Boyer, Andrew
2024-02-16 17:03 ` [PATCH v2] cryptodev: " Andrew Boyer
2024-02-16 17:18 ` Morten Brørup [this message]
2024-02-22 7:07 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F227@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.boyer@amd.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).