From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Ferruh Yigit" <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, <gmuthukrishn@marvell.com>,
<tangkunshan@huawei.com>, <techboard@dpdk.org>
Subject: RE: [PATCH 1/2] dma/skeleton: support SG copy ops
Date: Thu, 7 Mar 2024 14:15:26 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F2E4@smartserver.smartshare.dk> (raw)
In-Reply-To: <6153747.2l3rmUXbR5@thomas>
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, 7 March 2024 14.13
>
> 07/03/2024 11:44, Ferruh Yigit:
> > On 3/6/2024 8:48 PM, Thomas Monjalon wrote:
> > > 26/01/2024 09:57, Chengwen Feng:
> > >> Add support scatter gather copy.
> > >>
> > >> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > >> ---
> > >> --- a/drivers/dma/skeleton/skeleton_dmadev.c
> > >> +++ b/drivers/dma/skeleton/skeleton_dmadev.c
> > >> @@ -1,5 +1,5 @@
> > >> /* SPDX-License-Identifier: BSD-3-Clause
> > >> - * Copyright(c) 2021 HiSilicon Limited
> > >> + * Copyright(c) 2021-2024 HiSilicon Limited
> > >
> > > You should keep first year only.
> > > The rest has no value.
> > > It is just some noise in patches.
> > >
> > > Please read this:
> > > https://matija.suklje.name/how-and-why-to-properly-write-copyright-
> statements-in-your-code#why-not-bump-the-year-on-change
> > >
> >
> > Good read, thanks.
> >
> > +1 to keep the first year only and stop updating it
> > +1 to drop "All rights reserved." from copyright
> >
> > Should we document this as a project process to follow?
>
> We need a consensus.
Doesn't LF have some standard recommendations for this?
next prev parent reply other threads:[~2024-03-07 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 8:57 [PATCH 0/2] dma/skeleton: add support for SG copy and fill ops Chengwen Feng
2024-01-26 8:57 ` [PATCH 1/2] dma/skeleton: support SG copy ops Chengwen Feng
2024-03-06 20:48 ` Thomas Monjalon
2024-03-07 10:44 ` Ferruh Yigit
2024-03-07 13:12 ` Thomas Monjalon
2024-03-07 13:15 ` Morten Brørup [this message]
2024-01-26 8:57 ` [PATCH 2/2] dma/skeleton: support fill ops Chengwen Feng
2024-03-06 20:49 ` [PATCH 0/2] dma/skeleton: add support for SG copy and " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F2E4@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=gmuthukrishn@marvell.com \
--cc=tangkunshan@huawei.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).