From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"David Marchand" <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <bluca@debian.org>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: RE: [PATCH v2] test/lcores: reduce cpu consumption
Date: Thu, 7 Mar 2024 20:25:37 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F2F0@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240307183649.GA22674@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Thursday, 7 March 2024 19.37
>
> On Thu, Mar 07, 2024 at 07:06:26PM +0100, David Marchand wrote:
> > On Thu, Mar 7, 2024 at 3:16 PM David Marchand
> <david.marchand@redhat.com> wrote:
> > >
> > > Busy looping on RTE_MAX_LCORES threads is too heavy in some CI or
> build
> > > systems running the fast-test testsuite.
> > > Ask for a reschedule at the threads synchronisation points.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > Acked-by: Luca Boccassi <bluca@debian.org>
> >
> > Ideally, this test should be rewritten with some kind of OS-agnostic
> > synchronisation/scheduling API (mutex?).
> > But I think it will be enough for now.
>
> It's okay, I'll eventually get to this :)
>
For future reference, it seems SwitchToThread() [1] resembles sched_yield() [2].
[1]: https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-switchtothread
[2]: https://linux.die.net/man/2/sched_yield
> >
> > I updated the code comment as requested by Stephen.
> >
> > Applied, thanks.
> >
> > --
> > David Marchand
next prev parent reply other threads:[~2024-03-07 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 11:33 [PATCH] " David Marchand
2024-03-07 12:09 ` Luca Boccassi
2024-03-07 14:16 ` [PATCH v2] " David Marchand
2024-03-07 17:06 ` Stephen Hemminger
2024-03-07 17:08 ` Stephen Hemminger
2024-03-07 18:06 ` David Marchand
2024-03-07 18:36 ` Tyler Retzlaff
2024-03-07 19:25 ` Morten Brørup [this message]
2024-03-07 16:54 ` [PATCH] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F2F0@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).