From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
<konstantin.v.ananyev@yandex.ru>, <mattias.ronnblom@ericsson.com>,
<dev@dpdk.org>
Subject: RE: [PATCH v2] eal/x86: improve rte_memcpy const size 16 performance
Date: Thu, 4 Apr 2024 18:10:32 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F361@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240404085537.21469e1f@hermes.local>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 4 April 2024 17.56
>
> On Thu, 4 Apr 2024 17:37:53 +0200
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > > I would tend to agree with Stephen that whereever possible we should use
> > > the built-in memcpy calls. Hence my suggestion of re-introducing the
> macro.
> >
> > I agree in principle, but strongly prefer data to back up such changes in
> the fast path.
>
>
> godbolt.org shows same instructions for the cases I looked at.
Such a fundamental change belongs in a separate patch, with a description of what has been confirmed to generate same instructions or otherwise tested.
On behalf of the distros, I'm mostly worried about older compilers.
Anyway, this patch also tidies up the code, removing a lot of copy-paste, so I think we should go ahead with this patch first.
next prev parent reply other threads:[~2024-04-04 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 23:48 [PATCH] " Morten Brørup
2024-03-03 0:38 ` Morten Brørup
2024-03-03 5:40 ` Stephen Hemminger
2024-03-03 5:47 ` Stephen Hemminger
2024-03-03 5:58 ` Stephen Hemminger
2024-03-03 5:58 ` Stephen Hemminger
2024-03-03 10:07 ` Morten Brørup
2024-03-03 5:41 ` Stephen Hemminger
2024-03-03 9:46 ` [PATCH v2] " Morten Brørup
2024-04-04 9:18 ` Morten Brørup
2024-04-04 10:07 ` Bruce Richardson
2024-04-04 11:19 ` Morten Brørup
2024-04-04 13:29 ` Bruce Richardson
2024-04-04 15:37 ` Morten Brørup
2024-04-04 15:55 ` Stephen Hemminger
2024-04-04 16:10 ` Morten Brørup [this message]
2024-04-04 16:55 ` Bruce Richardson
2024-03-03 16:05 ` [PATCH] " Stephen Hemminger
2024-04-05 12:46 ` [PATCH v3] " Morten Brørup
2024-04-05 13:17 ` Bruce Richardson
2024-04-05 13:48 ` [PATCH v4] " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F361@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mattias.ronnblom@ericsson.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).