From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Chengwen Feng" <fengchengwen@huawei.com>
Cc: <dev@dpdk.org>, <huangdengdui@huawei.com>,
<stephen@networkplumber.org>, <roretzla@linux.microsoft.com>,
<thomas@monjalon.net>, <ferruh.yigit@amd.com>
Subject: RE: [PATCH v6] ethdev: fix strict aliasing lead to link cannot be up
Date: Mon, 15 Apr 2024 15:15:18 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F3A2@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240413084840.33124-1-fengchengwen@huawei.com>
> @@ -1701,12 +1696,8 @@ static inline void
> rte_eth_linkstatus_get(const struct rte_eth_dev *dev,
> struct rte_eth_link *link)
> {
> - RTE_ATOMIC(uint64_t) *src = (uint64_t __rte_atomic *)&(dev->data-
> >dev_link);
> - uint64_t *dst = (uint64_t *)link;
> -
> - RTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t));
> -
> - *dst = rte_atomic_load_explicit(src, rte_memory_order_seq_cst);
> + link->val64 = rte_atomic_load_explicit(&dev->data->dev_link.val64,
> + rte_memory_order_seq_cst);
> }
rte_eth_linkstatus_get() may be called by rte_eth_link_get():
https://elixir.bootlin.com/dpdk/v24.03/source/lib/ethdev/rte_ethdev.c#L2986
The application may call rte_eth_link_get() with the "link" parameter pointing to memory shared by other threads.
So link->val64 must be stored atomically:
rte_atomic_store_explicit(&link->val64,
rte_atomic_load_explicit(&dev->data->dev_link.val64,
rte_memory_order_seq_cst),
rte_memory_order_seq_cst);
With the above modification,
Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-04-15 13:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 3:07 [PATCH] " Chengwen Feng
2024-04-11 6:53 ` Morten Brørup
2024-04-11 6:58 ` Morten Brørup
2024-04-11 11:57 ` fengchengwen
2024-04-11 12:44 ` Morten Brørup
2024-04-11 12:04 ` [PATCH v3] " Chengwen Feng
2024-04-11 12:44 ` Morten Brørup
2024-04-12 3:27 ` fengchengwen
2024-04-12 7:24 ` Morten Brørup
2024-04-11 15:05 ` [PATCH] " Stephen Hemminger
2024-04-12 8:16 ` fengchengwen
2024-04-12 8:49 ` [PATCH v4] " Chengwen Feng
2024-04-13 8:04 ` [PATCH v5] " Chengwen Feng
2024-04-13 8:48 ` [PATCH v6] " Chengwen Feng
2024-04-15 13:15 ` Morten Brørup [this message]
2024-04-18 7:28 ` [PATCH v7] " Chengwen Feng
2024-04-19 15:15 ` Ferruh Yigit
2024-04-19 15:25 ` Ferruh Yigit
2024-04-22 6:42 ` fengchengwen
2024-04-22 6:38 ` [PATCH v8] " Chengwen Feng
2024-04-22 10:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F3A2@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=huangdengdui@huawei.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).