From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Gregory Etelson" <getelson@nvidia.com>
Cc: <alialnu@nvidia.com>, <dev@dpdk.org>, <mkashani@nvidia.com>,
<rasland@nvidia.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: RE: [PATCH v2] cmdline: increase input buffer size
Date: Wed, 1 May 2024 20:26:54 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F412@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240501171806.307533-1-getelson@nvidia.com>
+CC: Bruce, Stephen
> From: Gregory Etelson [mailto:getelson@nvidia.com]
> Sent: Wednesday, 1 May 2024 19.18
>
> DPDK defines cmdline input buffer size to 512 characters.
> That buffer size can be too small for long application input.
> For example, the following flow template API testpmd command is 444
> bytes long:
> ```
> flow queue 0 create 0 template_table 1000 \
> pattern_template 0 actions_template 0 postpone no \
> pattern eth / ipv4 / udp / end \
> actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \
> src_type value src_value 0x31 width 32 / \
> modify_field op set dst_type ipv4_src src_type value \
> src_value 10101010 width 32 / modify_field op add dst_type \
> ipv4_ttl dst_level 0 dst_offset 0 src_type value \
> src_value ff width 8 / count / jump group 100 / end
> ```
>
> The patch increases cmdline input buffer size to the LINE_MAX value.
+ ... , which typically is 2048.
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
With or without suggested patch description change,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-05-01 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:26 [PATCH] cmdline: configure " Gregory Etelson
2024-05-01 9:08 ` Bruce Richardson
2024-05-01 10:06 ` Etelson, Gregory
2024-05-01 14:42 ` Stephen Hemminger
2024-05-01 15:56 ` Etelson, Gregory
2024-05-01 16:30 ` Bruce Richardson
2024-05-01 17:18 ` [PATCH v2] cmdline: increase " Gregory Etelson
2024-05-01 18:26 ` Morten Brørup [this message]
2024-05-02 7:27 ` Bruce Richardson
2024-05-03 4:27 ` [PATCH v3] " Gregory Etelson
2024-05-15 8:41 ` Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F412@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=alialnu@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).