From: "Morten Brørup" <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <bruce.richardson@intel.com>,
<andremue@linux.microsoft.com>
Subject: RE: [RFC v3 0/8] Symbol versioning and export rework
Date: Tue, 11 Mar 2025 11:18:33 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FAE4@smartserver.smartshare.dk> (raw)
In-Reply-To: <20250311095609.194523-1-david.marchand@redhat.com>
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Tuesday, 11 March 2025 10.56
>
> So far, each DPDK library (or driver) exposing symbols in an ABI had to
> maintain a version.map and use some macros for symbol versioning,
> specially crafted with the GNU linker in mind.
>
> This series proposes to rework the whole principle, and instead rely on
> marking the symbol exports in the source code itself, then let it to
> the
> build framework to produce a version script adapted to the linker in
> use
> (think GNU linker vs MSVC linker).
>
> This greatly simplifies versioning symbols: a developer does not need
> to
> know anything about version.map, or that a versioned symbol must be
> renamed with _v26, annotated with __vsym, exported in a header etc...
>
> Checking symbol maps becomes unnecessary since generated by the build
> framework.
>
> Updating to a new ABI is just a matter of bumping the value in
> ABI_VERSION.
>
>
> Comments please.
Excellent. I'm all for automating this!
Feature creep:
Have you thought about how this (or related automation) can possibly also benefit the CI, e.g. for ABI breakage testing?
Or possible benefits to (automated) documentation of versioned functions?
Or possible benefits to remembering all versioned ABIs when writing the release notes?
next prev parent reply other threads:[~2025-03-11 10:18 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 21:23 [RFC] eal: add new function versioning macros David Marchand
2025-03-06 2:57 ` Patrick Robb
2025-03-06 10:23 ` Bruce Richardson
2025-03-06 12:50 ` [RFC v2 1/2] " David Marchand
2025-03-06 12:50 ` [RFC v2 2/2] build: generate symbol maps David Marchand
2025-03-06 15:45 ` [RFC v2 1/2] eal: add new function versioning macros Andre Muezerie
2025-03-11 9:55 ` [RFC v3 0/8] Symbol versioning and export rework David Marchand
2025-03-11 9:55 ` [RFC v3 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-11 9:56 ` [RFC v3 2/8] drivers: " David Marchand
2025-03-11 9:56 ` [RFC v3 3/8] eal: rework function versioning macros David Marchand
2025-03-13 16:53 ` Bruce Richardson
2025-03-13 17:09 ` David Marchand
2025-03-11 9:56 ` [RFC v3 4/8] buildtools: display version when listing symbols David Marchand
2025-03-11 9:56 ` [RFC v3 5/8] build: generate symbol maps David Marchand
2025-03-13 17:26 ` Bruce Richardson
2025-03-14 15:38 ` David Marchand
2025-03-14 14:24 ` Thomas Monjalon
2025-03-14 15:38 ` David Marchand
2025-03-14 15:27 ` Andre Muezerie
2025-03-14 15:51 ` David Marchand
2025-03-11 9:56 ` [RFC v3 6/8] build: mark exported symbols David Marchand
2025-03-13 17:30 ` Bruce Richardson
2025-03-14 16:14 ` David Marchand
2025-03-14 16:23 ` Bruce Richardson
2025-03-14 16:53 ` David Marchand
2025-03-14 17:21 ` David Marchand
2025-03-14 17:28 ` Bruce Richardson
2025-03-14 17:39 ` David Marchand
2025-03-14 17:51 ` Bruce Richardson
2025-03-11 9:56 ` [RFC v3 7/8] build: use dynamically generated version maps David Marchand
2025-03-11 9:56 ` [RFC v3 8/8] build: remove static " David Marchand
2025-03-11 10:18 ` Morten Brørup [this message]
2025-03-11 13:43 ` [RFC v3 0/8] Symbol versioning and export rework David Marchand
2025-03-17 15:42 ` [RFC v4 " David Marchand
2025-03-17 15:42 ` [RFC v4 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-17 15:42 ` [RFC v4 2/8] drivers: " David Marchand
2025-03-17 15:42 ` [RFC v4 3/8] eal: rework function versioning macros David Marchand
2025-03-17 15:43 ` [RFC v4 4/8] buildtools: display version when listing symbols David Marchand
2025-03-17 15:43 ` [RFC v4 5/8] build: generate symbol maps David Marchand
2025-03-19 16:19 ` Stephen Hemminger
2025-03-19 17:12 ` David Marchand
2025-03-20 15:06 ` Andre Muezerie
2025-03-17 15:43 ` [RFC v4 6/8] build: mark exported symbols David Marchand
2025-03-17 15:43 ` [RFC v4 7/8] build: use dynamically generated version maps David Marchand
2025-03-17 15:43 ` [RFC v4 8/8] build: remove static " David Marchand
2025-03-18 8:19 ` [RFC v4 0/8] Symbol versioning and export rework David Marchand
2025-03-26 12:02 ` David Marchand
2025-03-26 12:26 ` Morten Brørup
2025-03-26 13:07 ` Bruce Richardson
2025-03-26 13:36 ` Bruce Richardson
2025-03-26 13:54 ` David Marchand
2025-03-26 14:16 ` Bruce Richardson
2025-03-27 13:36 ` [PATCH v5 " David Marchand
2025-03-27 13:36 ` [PATCH v5 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-27 13:36 ` [PATCH v5 2/8] drivers: " David Marchand
2025-03-27 13:36 ` [PATCH v5 3/8] buildtools: display version when listing symbols David Marchand
2025-03-27 13:36 ` [PATCH v5 4/8] build: generate symbol maps David Marchand
2025-03-27 13:36 ` [PATCH v5 5/8] build: mark exported symbols David Marchand
2025-03-27 18:21 ` David Marchand
2025-03-27 13:36 ` [PATCH v5 6/8] build: use dynamically generated version maps David Marchand
2025-03-28 13:19 ` Aaron Conole
2025-03-27 13:36 ` [PATCH v5 7/8] build: remove static " David Marchand
2025-03-27 13:36 ` [PATCH v5 8/8] eal: rework function versioning macros David Marchand
2025-03-27 18:22 ` [PATCH v5 0/8] Symbol versioning and export rework David Marchand
2025-03-28 10:52 ` [PATCH v6 " David Marchand
2025-03-28 10:52 ` [PATCH v6 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-28 10:52 ` [PATCH v6 2/8] drivers: " David Marchand
2025-03-28 10:52 ` [PATCH v6 3/8] buildtools: display version when listing symbols David Marchand
2025-04-01 16:11 ` Thomas Monjalon
2025-04-01 19:04 ` David Marchand
2025-03-28 10:52 ` [PATCH v6 4/8] build: generate symbol maps David Marchand
2025-04-01 20:25 ` Thomas Monjalon
2025-04-02 7:00 ` David Marchand
2025-04-02 8:00 ` Thomas Monjalon
2025-04-01 20:33 ` Thomas Monjalon
2025-04-02 7:01 ` David Marchand
2025-04-02 8:05 ` Thomas Monjalon
2025-04-02 9:21 ` David Marchand
2025-03-28 10:52 ` [PATCH v6 5/8] build: mark exported symbols David Marchand
2025-04-02 9:01 ` Thomas Monjalon
2025-04-02 9:23 ` David Marchand
2025-03-28 10:52 ` [PATCH v6 6/8] build: use dynamically generated version maps David Marchand
2025-03-28 13:20 ` Aaron Conole
2025-03-28 10:52 ` [PATCH v6 7/8] build: remove static " David Marchand
2025-03-28 10:52 ` [PATCH v6 8/8] eal: rework function versioning macros David Marchand
2025-04-02 11:53 ` Thomas Monjalon
2025-04-02 12:16 ` David Marchand
2025-04-03 16:58 ` [PATCH v7 0/8] Symbol versioning and export rework David Marchand
2025-04-03 16:58 ` [PATCH v7 1/8] lib: remove incorrect exported symbols David Marchand
2025-04-03 16:58 ` [PATCH v7 2/8] drivers: " David Marchand
2025-04-04 5:47 ` Hemant Agrawal
2025-04-03 16:58 ` [PATCH v7 3/8] buildtools: display symbols version from map David Marchand
2025-04-03 16:58 ` [PATCH v7 4/8] build: generate symbol maps David Marchand
2025-04-03 16:58 ` [PATCH v7 5/8] build: mark exported symbols David Marchand
2025-04-04 5:48 ` Hemant Agrawal
2025-04-04 7:16 ` Andrew Rybchenko
2025-04-04 7:16 ` Andrew Rybchenko
2025-04-03 16:58 ` [PATCH v7 6/8] build: use dynamically generated version maps David Marchand
2025-04-03 16:58 ` [PATCH v7 7/8] build: remove static " David Marchand
2025-04-03 16:58 ` [PATCH v7 8/8] eal: rework function versioning macros David Marchand
2025-04-07 13:46 ` [PATCH v7 0/8] Symbol versioning and export rework David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9FAE4@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).