From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
Igor Russkikh <Igor.Russkikh@aquantia.com>
Subject: [dpdk-dev] [PATCH 04/10] net/atlantic: fix buffer overflow
Date: Sat, 2 Mar 2019 12:10:49 +0000 [thread overview]
Message-ID: <98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1551528549.git.igor.russkikh@aquantia.com>
From: Pavel Belous <Pavel.Belous@aquantia.com>
Found by Coverity
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>
---
drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
index 6841d9bce..a155d4aab 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
@@ -501,7 +501,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len)
/* Write SMBUS request to cfg memory */
err = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,
(u32 *)(void *)&request,
- RTE_ALIGN(sizeof(request), sizeof(u32)));
+ RTE_ALIGN(sizeof(request) / sizeof(u32), sizeof(u32)));
if (err < 0)
return err;
@@ -523,7 +523,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len)
err = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),
&result,
- RTE_ALIGN(sizeof(result), sizeof(u32)));
+ RTE_ALIGN(sizeof(result) / sizeof(u32), sizeof(u32)));
if (err < 0)
return err;
@@ -558,7 +558,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len)
/* Write SMBUS request to cfg memory */
err = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,
(u32 *)(void *)&request,
- RTE_ALIGN(sizeof(request), sizeof(u32)));
+ RTE_ALIGN(sizeof(request) / sizeof(u32), sizeof(u32)));
if (err < 0)
return err;
@@ -589,7 +589,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len)
/* Read status of write operation */
err = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),
&result,
- RTE_ALIGN(sizeof(result), sizeof(u32)));
+ RTE_ALIGN(sizeof(result) / sizeof(u32), sizeof(u32)));
if (err < 0)
return err;
--
2.17.1
next prev parent reply other threads:[~2019-03-02 12:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 12:10 [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 01/10] net/atlantic: Fix negative error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 02/10] net/atlantic: remove unused variable Igor Russkikh
2019-03-04 21:22 ` Rami Rosen
2019-03-02 12:10 ` [dpdk-dev] [PATCH 03/10] net/atlantic: check for error codes Igor Russkikh
2019-03-02 12:10 ` Igor Russkikh [this message]
2019-03-02 12:10 ` [dpdk-dev] [PATCH 05/10] net/atlantic: use eeprom magic as a device address Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 06/10] net/atlantic: fix eeprom fetching for small and uneven lengths Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 07/10] net/atlantic: fix link configuration Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 09/10] net/atlantic: fix missing vlan filter offload Igor Russkikh
2019-03-02 12:11 ` [dpdk-dev] [PATCH 10/10] net/atlantic: fix xstats to return correct number of requested items Igor Russkikh
2019-03-04 21:12 ` Rami Rosen
2019-03-04 9:40 ` [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup David Marchand
2019-03-06 12:08 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).