From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Chautru, Nicolas" <nicolas.chautru@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Vargas, Hernan" <hernan.vargas@intel.com>,
"Marchand, David" <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH 1/2] baseband/fpga_5gnr_fec: use new barrier API
Date: Mon, 26 Feb 2024 12:03:57 +0100 [thread overview]
Message-ID: <99571564-348b-45b6-b07e-32ffbb89faee@redhat.com> (raw)
In-Reply-To: <BY5PR11MB4451018C8D2D61965A94C747F8562@BY5PR11MB4451.namprd11.prod.outlook.com>
Hello,
On 2/22/24 19:05, Chautru, Nicolas wrote:
> Hi Maxime,
>
> Why would we change this here and now? Is the intent not to use new suggested semantics for new patches only?
The pull request was rejected because of the use of such barrier, which
is reported by checkpatch.
### [PATCH] baseband/fpga_5gnr_fec: add AGX100 support
Warning in drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c:
Using rte_smp_[r/w]mb
> Are all DPDK drivers being changed?
My understanding is that for now, only new occurrences are prohibited,
can you confirm Tyler?
If so we could only change for now the patch adding ACX100.
But... I preferred doing the changes for all bbdev drivers for
consistency.
> I am unsure we would want to change these drivers, this is kind of risk introduced by code churn that gets ecosystem unwilling to move to latest version.
I think it is better to change now that we are far from the next LTS.
> These memory barriers issues are awful to troubleshoot or properly validate, so personally quite reluctant to change.
If I disassemble fpga_dequeue_enc() with and without the patch, I cannot
spot a difference.
Thomas, are you waiting for this series to be applied to take the pull
request that was initially for -rc1?
Thanks,
Maxime
> Thanks
> Nic
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, February 22, 2024 8:21 AM
>> To: dev@dpdk.org; Chautru, Nicolas <nicolas.chautru@intel.com>; Vargas,
>> Hernan <hernan.vargas@intel.com>; Marchand, David
>> <david.marchand@redhat.com>; thomas@monjalon.net;
>> roretzla@linux.microsoft.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH 1/2] baseband/fpga_5gnr_fec: use new barrier API
>>
>> rte_smp_rmb() is deprecated, use the new API instead as suggested in
>> rte_atomic header.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
>> b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
>> index efc1d3a772..314c87350e 100644
>> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
>> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
>> @@ -2661,7 +2661,7 @@ vc_5gnr_dequeue_ldpc_enc_one_op_cb(struct
>> fpga_5gnr_queue *q, struct rte_bbdev_e
>> return -1;
>>
>> /* make sure the response is read atomically */
>> - rte_smp_rmb();
>> + rte_atomic_thread_fence(rte_memory_order_acquire);
>>
>> rte_bbdev_log_debug("DMA response desc %p", desc);
>>
>> @@ -2690,7 +2690,7 @@ agx100_dequeue_ldpc_enc_one_op_cb(struct
>> fpga_5gnr_queue *q, struct rte_bbdev_en
>> return -1;
>>
>> /* make sure the response is read atomically. */
>> - rte_smp_rmb();
>> + rte_atomic_thread_fence(rte_memory_order_acquire);
>>
>> rte_bbdev_log_debug("DMA response desc %p", desc);
>>
>> @@ -2722,7 +2722,7 @@ vc_5gnr_dequeue_ldpc_dec_one_op_cb(struct
>> fpga_5gnr_queue *q, struct rte_bbdev_d
>> return -1;
>>
>> /* make sure the response is read atomically */
>> - rte_smp_rmb();
>> + rte_atomic_thread_fence(rte_memory_order_acquire);
>>
>> #ifdef RTE_LIBRTE_BBDEV_DEBUG
>> vc_5gnr_print_dma_dec_desc_debug_info(desc);
>> @@ -2768,7 +2768,7 @@ agx100_dequeue_ldpc_dec_one_op_cb(struct
>> fpga_5gnr_queue *q, struct rte_bbdev_de
>> return -1;
>>
>> /* make sure the response is read atomically. */
>> - rte_smp_rmb();
>> + rte_atomic_thread_fence(rte_memory_order_acquire);
>>
>> #ifdef RTE_LIBRTE_BBDEV_DEBUG
>> agx100_print_dma_dec_desc_debug_info(desc);
>> --
>> 2.43.0
>
next prev parent reply other threads:[~2024-02-26 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:21 Maxime Coquelin
2024-02-22 16:21 ` [PATCH 2/2] baseband/fpga_lte_fec: " Maxime Coquelin
2024-02-22 18:05 ` [PATCH 1/2] baseband/fpga_5gnr_fec: " Chautru, Nicolas
2024-02-26 11:03 ` Maxime Coquelin [this message]
2024-02-27 16:56 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99571564-348b-45b6-b07e-32ffbb89faee@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).