From: "Hunt, David" <david.hunt@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map
Date: Mon, 2 Oct 2017 17:25:34 +0100 [thread overview]
Message-ID: <995cb4f2-44e0-9c4e-45ac-b97a2199a0f9@intel.com> (raw)
In-Reply-To: <1917865.rASfWJCVJS@xps>
Hi Thomas,
On 2/10/2017 4:39 PM, Thomas Monjalon wrote:
> 02/10/2017 17:06, Hunt, David:
>> On 2/10/2017 3:55 PM, Thomas Monjalon wrote:
>>> +DPDK_17.11 {
>>>> + global:
>>>> +
>>>> + rte_power_acpi_turbo_status;
>>> Is it really the function you want to expose?
>>> rte_power_turbo_status seems more generic.
>> Not really, it was in there for completeness, but users should be able
>> to keep track of the turbo'd cores, so not really needed.
>>
>>> More comments about what is part of the API:
>>> If you do not want to expose ACPI and VM implementations,
>>> it should not be part of the rte_* include files.
>> I'll address the above comments in the next version.
> You did not address the comment about what is rte_*.h.
> If you do not want to expose everything, you should move it to
> another .h file.
>
> Files starting with rte_ are included in doxygen API doc.
> Only rte_power.h is installed.
> The installed include, the doxygen doc and the map file
> should all expose the same API consistently.
>
> I think a cleanup is needed.
While I agree a cleanup is needed, this small patch is only intended to
fix the priority issue of the shared library builds, which are broken at
the moment.
The initial patch should have had rte_power_turbo_status, not
rte_power_acpi_turbo_status.
Rather than moving code around at this stage, I propose having the three
exposed functions in the map file (with the correct names).
Then, later on, I can do an ABI breakage notification for the next
release to rename all the other rte*.h files, as some consumers of DPDK
may be using those directly, at which stage we will be down to just
exporting the functions in rte_power.h.
Does that sound OK with you?
Regards,
Dave.
next prev parent reply other threads:[~2017-10-02 16:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 12:20 David Hunt
2017-10-02 14:53 ` [dpdk-dev] [PATCH v2] power: add turbo functions to map file David Hunt
2017-10-03 7:22 ` [dpdk-dev] [PATCH v3] " David Hunt
2017-10-03 8:40 ` Thomas Monjalon
2017-10-02 14:55 ` [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map Thomas Monjalon
2017-10-02 15:06 ` Hunt, David
2017-10-02 15:39 ` Thomas Monjalon
2017-10-02 16:25 ` Hunt, David [this message]
2017-10-02 16:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995cb4f2-44e0-9c4e-45ac-b97a2199a0f9@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).