From: "Sun, Xutao" <xutao.sun@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vmdq: Fix the core dump issue when mem_pool is more than 34
Date: Thu, 15 Oct 2015 07:54:36 +0000 [thread overview]
Message-ID: <9AC567D38896294095E6F3228F697FC8021C1F96@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C833BF9@IRSMSX108.ger.corp.intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, October 13, 2015 3:59 PM
> To: Sun, Xutao; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] examples/vmdq: Fix the core dump issue
> when mem_pool is more than 34
>
> Hi Xutao,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xutao Sun
> > Sent: Tuesday, October 13, 2015 8:29 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] examples/vmdq: Fix the core dump issue
> > when mem_pool is more than 34
> >
> > Macro MAX_QUEUES was defined to 128, only allow 16 mem_pools in
> > theory.
> > When running vmdq_app with more than 34 mem_pools, it will cause the
> > core_dump issue.
> > Change MAX_QUEUES to 1024 will solve this issue.
> >
> > Signed-off-by: Xutao Sun <xutao.sun@intel.com>
> > ---
> > examples/vmdq/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
> > a142d49..b463cfb 100644
> > --- a/examples/vmdq/main.c
> > +++ b/examples/vmdq/main.c
> > @@ -69,7 +69,7 @@
> > #include <rte_mbuf.h>
> > #include <rte_memcpy.h>
> >
> > -#define MAX_QUEUES 128
> > +#define MAX_QUEUES 1024
> > /*
> > * For 10 GbE, 128 queues require roughly
> > * 128*512 (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port.
> > --
> > 1.9.3
>
> Just for clarification, when you say mem_pools, do you mean vmdq pools?
> Also, if you are going to increase MAX_QUEUES, shouldn't you increase the
> NUM_MBUFS_PER_PORT?
> Looking at the comment below, looks like there is a calculation of number of
> mbufs based on number of queues.
> Plus, I assume 128 is the maximum number of queues per port, and as far as I
> know, only Fortville supports 256 as maximum.
>
> Thanks,
> Pablo
Hi Pablo,
I mean vmdq pools when I say mem_pools.
And as you say, NUM_MBUFS_PER_PORT should be increased actually.
I may use macro to replace the old expression.
#define NUM_MBUFS_PER_PORT (MAX_QUEUES * max(RTE_TEST_RX_DESC_DEFAULT,RTE_TEST_TX_DESC_DEFAULT))
And this patch is to fix the issue about running VMDQ on Fortville, so the maximum number of queues is larger than 128.
Thank you very much for your advice!
Thanks,
Xutao
next prev parent reply other threads:[~2015-10-15 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 7:29 Xutao Sun
2015-10-13 7:59 ` De Lara Guarch, Pablo
2015-10-15 7:54 ` Sun, Xutao [this message]
2015-10-27 5:10 ` [dpdk-dev] [PATCH v2] " Xutao Sun
2015-10-27 7:55 ` De Lara Guarch, Pablo
2015-10-27 8:22 ` Sun, Xutao
2015-10-27 8:58 ` [dpdk-dev] [PATCH v3] " Xutao Sun
2015-10-29 7:53 ` De Lara Guarch, Pablo
2015-12-07 1:46 ` Thomas Monjalon
2015-10-30 5:54 ` [dpdk-dev] [PATCH v2] " Wu, Jingjing
[not found] <1442814327-29336-1-git-send-email-xutao.sun@intel.com>
2015-09-21 6:43 ` [dpdk-dev] [PATCH] " Wu, Jingjing
2015-09-21 7:19 ` Xu, Qian Q
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9AC567D38896294095E6F3228F697FC8021C1F96@shsmsx102.ccr.corp.intel.com \
--to=xutao.sun@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).