From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fiX statstic inconsistent when port stopped
Date: Fri, 29 Jul 2016 02:49:52 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F80E17324D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1469498772-66958-1-git-send-email-wei.zhao1@intel.com>
Hi, zhaowei
Few comments below:
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao1
> Sent: Tuesday, July 26, 2016 10:06 AM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH] net/i40e: fiX statstic inconsistent when port
> stopped
>
Avoid typo:
fiX -> fix;
statstic -> statistic
And there are some requirements based on the subject and commit log in , such as:
* The summary line should be around 50 characters.
* The text of the commit message should be wrapped at 72 characters.
Please check the doc " doc/guides/contributing/patches.rst" and use " scripts/check-git-log.sh" to help you.
> rx_good_bytes and rx_good_packets statstic is inconsistent when port
> stopped,ipackets statistic is minus the discard packets but rx_bytes statistic
> not.
> Also,i40e has no statstic of discard bytes, so we have to delete discard
> packets item from rx_good_packets statstic.
>
> Fixes: 9aace75fc82e ("i40e: fix statistics")
>
> Signed-off-by: Wei Zhao1 <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 11a5804..553dfd9 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2319,8 +2319,7 @@ i40e_dev_stats_get(struct rte_eth_dev *dev,
> struct rte_eth_stats *stats)
>
> stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
> pf->main_vsi->eth_stats.rx_multicast +
> - pf->main_vsi->eth_stats.rx_broadcast -
> - pf->main_vsi->eth_stats.rx_discards;
> + pf->main_vsi->eth_stats.rx_broadcast;
> stats->opackets = pf->main_vsi->eth_stats.tx_unicast +
> pf->main_vsi->eth_stats.tx_multicast +
> pf->main_vsi->eth_stats.tx_broadcast;
rx_discards is included in imiss. So I think it's better to minus the discard count.
/Jingjing
next prev parent reply other threads:[~2016-07-29 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 2:06 Wei Zhao1
2016-07-29 2:49 ` Wu, Jingjing [this message]
2016-07-29 6:02 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F80E17324D@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).