From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix parsing QinQ packets type issue
Date: Sun, 21 Aug 2016 01:21:19 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F80E17D64E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1471576805-16857-1-git-send-email-beilei.xing@intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Friday, August 19, 2016 11:20 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH] net/i40e: fix parsing QinQ packets type issue
>
> Previously, PTYPE filed in the RX descriptors is not set properly
> for QinQ packets, wrong PTYPE is generated because outer Tag did
> not have ORT/PIT configured.
> Fix this issue by configuring ORT/PIT.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 55c4887..ba0eca0 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -747,8 +747,10 @@ static inline void i40e_flex_payload_reg_init(struct i40e_hw *hw)
> I40E_WRITE_REG(hw, I40E_GLQF_ORT(20), 0x00000031);
> I40E_WRITE_REG(hw, I40E_GLQF_ORT(23), 0x00000031);
> I40E_WRITE_REG(hw, I40E_GLQF_ORT(63), 0x0000002D);
> + I40E_WRITE_REG(hw, I40E_GLQF_ORT(40), 0x00000029);
Setting of GLQF_ORT(40) and GLQF_PIT(16) is for outer vlan, but not for Flexible payload.
So it may not be suitable to put the code in i40e_flex_payload_reg_init.
How about change the function's name and add comments in code?
> /* GLQF_PIT Registers */
> + I40E_WRITE_REG(hw, I40E_GLQF_PIT(9), 0x00009420);
> I40E_WRITE_REG(hw, I40E_GLQF_PIT(16), 0x00007480);
> I40E_WRITE_REG(hw, I40E_GLQF_PIT(17), 0x00007440);
> }
> --
> 2.5.0
next prev parent reply other threads:[~2016-08-21 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 3:20 Beilei Xing
2016-08-21 1:21 ` Wu, Jingjing [this message]
2016-08-23 9:44 ` [dpdk-dev] [PATCH v2] " Beilei Xing
2016-09-05 5:36 ` Wu, Jingjing
2016-09-12 9:41 ` [dpdk-dev] [PATCH v3] " Beilei Xing
2016-09-22 7:40 ` Wu, Jingjing
2016-09-23 11:00 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F80E17D64E@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).