From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix VF bonded device link down
Date: Tue, 25 Oct 2016 10:45:14 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F80E2946CE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1477369146-63317-2-git-send-email-qiming.yang@intel.com>
> -----Original Message-----
> From: Yang, Qiming
> Sent: Tuesday, October 25, 2016 12:19 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Subject: [PATCH v2 2/2] net/i40e: fix VF bonded device link down
>
> If VF device is used as slave of a bond device, it will be polled
> periodically through alarm. Interrupt is involved here. And then
> VF will send I40E_VIRTCHNL_OP_GET_LINK_STAT message to
> PF to query the status. The response is handled by interrupt
> callback. Interrupt is involved here again. That's why bond
> device cannot bring up.
>
> This patch removes I40E_VIRTCHNL_OP_GET_LINK_STAT
> message. Link status in VF driver will be updated when PF driver
> notify it, and VF stores this link status locally. VF driver just
> returns the local status when being required.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Thanks.
BTW, next time, don't forget to note your changes comparing the previous version.
It will make reviewers' life easy. :)
/Jingjing
next prev parent reply other threads:[~2016-10-25 10:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 4:19 [dpdk-dev] [PATCH v2 1/2] net/i40e: fix link status change interrupt Qiming Yang
2016-10-25 4:19 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-10-25 10:45 ` Wu, Jingjing [this message]
2016-10-28 4:18 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: fix link status change interrupt Qiming Yang
2016-10-28 4:18 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-10-28 11:05 ` Ferruh Yigit
2016-11-04 9:10 ` [dpdk-dev] [PATCH v4 1/2] net/i40e: fix link status change interrupt Qiming Yang
2016-11-04 9:10 ` [dpdk-dev] [PATCH v4 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-11-07 16:48 ` Thomas Monjalon
2016-10-25 10:43 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix link status change interrupt Wu, Jingjing
2016-10-25 12:53 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F80E2946CE@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).