From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev v2 3/3] test: enable HW CRC strip by default
Date: Wed, 22 Mar 2017 12:26:47 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810CF987F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1490003874-37766-3-git-send-email-jia.guo@intel.com>
> -----Original Message-----
> From: Guo, Jia
> Sent: Monday, March 20, 2017 5:58 PM
> To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev v2 3/3] test: enable HW CRC strip by default
>
> Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers,
> and for most case of kernel driver default enable HW CRC strip, if disable HW
> CRC strip in test app's rxmode, VF driver will return fail and result the VF launch
> failure. So this patch default to enable HW CRC strip to let VF launch successful.
>
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> Cc: stable@dpdk.org
> ---
> test/test-pipeline/init.c | 2 +-
> test/test/test_kni.c | 2 +-
> test/test/test_link_bonding.c | 4 ++--
> test/test/test_link_bonding_mode4.c | 2 +-
> test/test/test_link_bonding_rssconf.c | 4 ++--
> test/test/test_pmd_perf.c | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c index
> aef082f..00dbc27 100644
> --- a/test/test-pipeline/init.c
> +++ b/test/test-pipeline/init.c
> @@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf = {
> .hw_ip_checksum = 1, /* IP checksum offload enabled */
> .hw_vlan_filter = 0, /* VLAN filtering disabled */
> .jumbo_frame = 0, /* Jumbo Frame Support disabled */
> - .hw_strip_crc = 0, /* CRC stripped by hardware */
> + .hw_strip_crc = 1, /* CRC stripped by hardware */
> },
> .rx_adv_conf = {
> .rss_conf = {
> diff --git a/test/test/test_kni.c b/test/test/test_kni.c index 309741c..db17fdf
> 100644
> --- a/test/test/test_kni.c
> +++ b/test/test/test_kni.c
> @@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf = {
> .hw_ip_checksum = 0,
> .hw_vlan_filter = 0,
> .jumbo_frame = 0,
> - .hw_strip_crc = 0,
> + .hw_strip_crc = 1,
> },
> .txmode = {
> .mq_mode = ETH_DCB_NONE,
> diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c index
> 3229660..3a1194c 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode = {
> .hw_vlan_strip = 1, /**< VLAN strip enabled. */
> .hw_vlan_extend = 0, /**< Extended VLAN disabled. */
> .jumbo_frame = 0, /**< Jumbo Frame Support disabled. */
> - .hw_strip_crc = 0, /**< CRC stripping by hardware disabled. */
> + .hw_strip_crc = 1, /**< CRC stripping by hardware disabled. */
> };
Comment "/**< CRC stripping by hardware disabled. */" need to be
Changed too.
next prev parent reply other threads:[~2017-03-22 12:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:57 [dpdk-stable] [dpdk-dev v2 1/3] examples: " Jeff Guo
2017-03-20 9:57 ` [dpdk-stable] [dpdk-dev v2 2/3] app: " Jeff Guo
2017-03-22 12:22 ` Wu, Jingjing
2017-03-22 12:24 ` Wu, Jingjing
2017-03-23 3:40 ` [dpdk-stable] [dpdk-dev v3 1/3] examples: " Jeff Guo
2017-03-23 3:40 ` [dpdk-stable] [dpdk-dev v3 2/3] app: " Jeff Guo
2017-03-23 3:40 ` [dpdk-stable] [dpdk-dev v3 3/3] test: " Jeff Guo
2017-03-23 5:43 ` [dpdk-stable] [dpdk-dev v3 1/3] examples: " Jeff Guo
2017-03-23 5:43 ` [dpdk-stable] [dpdk-dev v3 2/3] app: " Jeff Guo
2017-03-23 6:43 ` Wu, Jingjing
2017-03-23 5:43 ` [dpdk-stable] [dpdk-dev v3 3/3] test: " Jeff Guo
2017-03-23 6:43 ` Wu, Jingjing
2017-04-08 5:56 ` [dpdk-stable] [dpdk-dev v4 1/3] examples: " Jeff Guo
2017-04-08 5:56 ` [dpdk-stable] [dpdk-dev v4 2/3] app: " Jeff Guo
2017-04-08 5:56 ` [dpdk-stable] [dpdk-dev v4 3/3] test: " Jeff Guo
2017-04-10 20:37 ` [dpdk-stable] [dpdk-dev v4 1/3] examples: " Thomas Monjalon
2017-03-23 6:43 ` [dpdk-stable] [dpdk-dev v3 " Wu, Jingjing
2017-03-20 9:57 ` [dpdk-stable] [dpdk-dev v2 3/3] test: " Jeff Guo
2017-03-22 12:26 ` Wu, Jingjing [this message]
2017-03-23 3:55 ` Guo, Jia
2017-03-22 11:53 ` [dpdk-stable] [dpdk-dev v2 1/3] examples: " Wu, Jingjing
2017-03-22 12:28 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810CF987F@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).