From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode
Date: Fri, 24 Mar 2017 09:34:07 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D13401@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B57F136@shsmsx102.ccr.corp.intel.com>
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, March 24, 2017 3:07 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode
>
> Hi Jingjing,
>
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Friday, March 24, 2017 1:20 PM
> > To: Lu, Wenzhuo; dev@dpdk.org
> > Cc: Lu, Wenzhuo
> > Subject: RE: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority
> > mode
> >
> >
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > > Sent: Friday, February 24, 2017 11:25 AM
> > > To: dev@dpdk.org
> > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > > Subject: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority
> > > mode
> > >
> > > Set some TCs to strict priority mode.
> > > It's a global setting on a physical port.
> > >
> > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > > ---
> > > doc/guides/nics/i40e.rst | 10 +++
> > > doc/guides/rel_notes/release_17_05.rst | 7 ++
> > > drivers/net/i40e/i40e_ethdev.c | 119
> > > ++++++++++++++++++++++++++++++
> > > drivers/net/i40e/i40e_ethdev.h | 1 +
> > > drivers/net/i40e/rte_pmd_i40e.h | 15 ++++
> > > drivers/net/i40e/rte_pmd_i40e_version.map | 1 +
> > > 6 files changed, 153 insertions(+)
> > >
> > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
> > > index
> > > 260287e..361d9d9 100644
> > > --- a/doc/guides/nics/i40e.rst
> > > +++ b/doc/guides/nics/i40e.rst
> > > @@ -478,3 +478,13 @@ enabled. If so, return failure.
> > > When enabling per TC max bandwidth, SW will check if per VF max
> > > bandwidth is enabled. If so, disable per VF max bandwidth and
> > > continue with per TC max bandwidth setting.
> > > +
> > > +TC TX scheduling mode setting
> > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > +
> > > +There're 2 TX scheduling modes for TCs, round robin and strict
> > > +priority
> > mode.
> > > +If a TC is set to strict priority mode, it can consume unlimited bandwidth.
> > > +It means if APP has set the max bandwidth for that TC, it comes to
> > > +no effect.
> > > +It's suggested to set the strict priority mode for a TC that is
> > > +latency sensitive but no consuming much bandwidth.
> > > diff --git a/doc/guides/rel_notes/release_17_05.rst
> > > b/doc/guides/rel_notes/release_17_05.rst
> > > index d31435c..99811a2 100644
> > > --- a/doc/guides/rel_notes/release_17_05.rst
> > > +++ b/doc/guides/rel_notes/release_17_05.rst
> > > @@ -55,6 +55,13 @@ New Features
> > > i40e HW supports to set the max bandwidth for a TC on a VF. Enable this
> > > capability.
> > >
> > > +* **Added TC strict priority mode setting on i40e.**
> > > +
> > > + There're 2 TX scheduling modes supported for TCs by i40e HW,
> > > + round ribon mode and strict priority mode. By default it's round
> > > + robin mode. Enable the capability to change the TX scheduling
> > > + mode for a TC. It's a global setting on a physical port.
> > > +
> > > Resolved Issues
> >
> >
> > > + if (!veb->strict_prio_tc)
> > > + ret = i40e_aq_config_switch_comp_ets(
> > > + hw, veb->uplink_seid,
> > > + &ets_data,
> > i40e_aqc_opc_enable_switching_comp_ets,
> > > + NULL);
> >
> > How about to check the tc_map when the first time to set strict_prio_tc?
> Thanks for the comment. I didn't consider that before.
> But I checked my patch, in the previous code, I've checked if tc_map is equal to
> strict_prio_tc. So if it's the first time to set strict_prio_tc, tc_map cannot be 0.
> Lucky :)
OK. Then I'm fine to ACK this patch.
Acked-by Jingjing Wu <jingjing.wu@intel.com>
next prev parent reply other threads:[~2017-03-24 9:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 3:24 [dpdk-dev] [PATCH 0/8] QoS features on i40e Wenzhuo Lu
2017-02-24 3:24 ` [dpdk-dev] [PATCH 1/8] net/i40e: set VF max bandwidth from PF Wenzhuo Lu
2017-03-24 5:01 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 2/8] net/i40e: allocate VF TC " Wenzhuo Lu
2017-03-24 5:10 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 3/8] net/i40e: set VF TC max " Wenzhuo Lu
2017-03-24 5:15 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode Wenzhuo Lu
2017-03-24 5:19 ` Wu, Jingjing
2017-03-24 7:07 ` Lu, Wenzhuo
2017-03-24 9:34 ` Wu, Jingjing [this message]
2017-02-24 3:24 ` [dpdk-dev] [PATCH 5/8] app/testpmd: set VF TX max bandwidth Wenzhuo Lu
2017-03-24 5:21 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 6/8] app/testpmd: set VF TC TX min bandwidth Wenzhuo Lu
2017-03-24 5:22 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 7/8] app/testpmd: set VF TC TX max bandwidth Wenzhuo Lu
2017-03-24 5:22 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 8/8] app/testpmd: set TC strict link priority mode Wenzhuo Lu
2017-03-24 5:23 ` Wu, Jingjing
2017-02-24 6:55 ` [dpdk-dev] [PATCH 0/8] QoS features on i40e Stephen Hemminger
2017-02-24 7:23 ` Lu, Wenzhuo
2017-02-24 9:14 ` [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence Vincent JARDIN
2017-02-28 5:04 ` Lu, Wenzhuo
2017-03-27 15:13 ` [dpdk-dev] [PATCH 0/8] QoS features on i40e Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D13401@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).