From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/i40e: implement device reset on port
Date: Thu, 30 Mar 2017 07:02:38 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D1B274@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1490688547-4831-3-git-send-email-wei.zhao1@intel.com>
Looks good, just minor comment
> +static int
> +i40evf_reset_dev(struct rte_eth_dev *dev) {
> + struct i40e_adapter *adapter =
> + I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> +
> + adapter->reset_flag = 1;
> + i40evf_store_before_reset(dev);
> +
> + i40evf_dev_close(dev);
> + PMD_DRV_LOG(DEBUG, "i40evf dev close complete");
> +
> + i40evf_dev_uninit(dev);
> + PMD_DRV_LOG(DEBUG, "i40evf dev detached");
> +
> + memset(dev->data->dev_private, 0,
> + (uint64_t)&adapter->reset_flag - (uint64_t)adapter);
You can use offset() instead.
next prev parent reply other threads:[~2017-03-30 7:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:09 [dpdk-dev] [PATCH v3 0/3] net/i40e: vf port reset Wei Zhao
2017-03-28 8:09 ` [dpdk-dev] [PATCH v3 1/3] lib/librte_ether: add support for " Wei Zhao
2017-03-28 8:09 ` [dpdk-dev] [PATCH v3 2/3] net/i40e: implement device reset on port Wei Zhao
2017-03-30 7:02 ` Wu, Jingjing [this message]
2017-03-28 8:09 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-03-30 8:55 ` Wu, Jingjing
2017-03-30 8:58 ` Zhao1, Wei
2017-03-30 8:57 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D1B274@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).