From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Oleg Kuporosov <olegk@mellanox.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps
Date: Fri, 28 Apr 2017 00:19:30 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D59753@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <5493210.cW0TSkhqM8@xps>
> 25/04/2017 16:02, Wu, Jingjing:
> > From: Oleg Kuporosov
> > > Implemented two methods of control
> > >
> > > - by --enable-timestamps CL testpmd application we can enable
> timestamping
> > > for all ports;
> > > - in interactive mode port config <port> timestamps on|off is able to
> > > configure timestamping per specific port.
> > >
> > > The control doesn't interact with IEEE1588 PTP implementation there
> > > as it is under macro compilation but can be extended in the future.
> > >
> > > This feature is required for debugging/testing purposes for real
> > > time HW packet timestamping.
> >
> > We have ieee1588fwd.c to demo the timesync enable/disable, can we
> > reuse The fwd engine instead of defining new commands?
>
> Yes for IEEE1588 feature, we should use app/test-pmd/ieee1588fwd.c.
>
> There is more to say about this feature.
>
> The main goal of this patchset was to add a timestamp in the mbuf.
> It has been done by another patchset in 17.05.
OK. But it is not clear now what is the timestamp for, right?
> Do we know how to test this timestamp in testpmd?
>
Mbuf dump can show this value. The problem is if we can use the
rte_eth_timesync_enable/disable to indicate the timestamp
is in mbuf or not.
> About IEEE1588 feature, why is there a config option?
> CONFIG_RTE_LIBRTE_IEEE1588
> A feature should never be disabled at compile time.
> There is also a runtime enablement with rte_eth_timesync_enable().
>
> I think we need some discussions here.
Yes, I agree.
> Thanks
next prev parent reply other threads:[~2017-04-28 0:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 14:35 [dpdk-dev] [PATCH 0/3] Improvements in packet timestamps support Oleg Kuporosov
2016-10-13 14:35 ` [dpdk-dev] [PATCH 1/3] mbuf: embedding timestamp into the packet Oleg Kuporosov
2016-10-18 15:43 ` Olivier Matz
2016-10-19 10:14 ` Pattan, Reshma
2016-10-19 17:40 ` Oleg Kuporosov
2016-10-25 12:39 ` Pattan, Reshma
2016-10-19 13:31 ` Ananyev, Konstantin
2016-10-20 8:03 ` Oleg Kuporosov
2016-10-20 10:57 ` Jan Blunck
2016-10-19 17:08 ` Oleg Kuporosov
2017-01-24 15:27 ` Olivier MATZ
2016-10-13 14:35 ` [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps Oleg Kuporosov
2017-04-25 14:02 ` Wu, Jingjing
2017-04-25 16:22 ` Thomas Monjalon
2017-04-28 0:19 ` Wu, Jingjing [this message]
2017-04-28 9:12 ` Thomas Monjalon
2017-04-28 10:04 ` Olivier Matz
2016-10-13 14:35 ` [dpdk-dev] [PATCH 3/3] net/mlx5: implementation of Rx packet timestamping support Oleg Kuporosov
2016-10-17 11:24 ` [dpdk-dev] [PATCH 0/3] Improvements in packet timestamps support Nélio Laranjeiro
2017-10-17 13:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D59753@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=olegk@mellanox.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).