From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Pei, Yulong" <yulong.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: initalize port_numa and ring_numa
Date: Fri, 28 Apr 2017 07:36:29 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D59D9A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1493018159-6882-1-git-send-email-yulong.pei@intel.com>
> -----Original Message-----
> From: Pei, Yulong
> Sent: Monday, April 24, 2017 3:16 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; thomas@monjalon.net; Pei, Yulong
> <yulong.pei@intel.com>
> Subject: [PATCH] app/testpmd: initalize port_numa and ring_numa
>
> Previous numa_support = 0 by default, it need to add --numa to testpmd
> command line to enable numa, so port_numa and ring_numa were initalized at
> function launch_args_parse(), now testpmd change numa_support = 1 as
> default, so port_numa and ring_numa also need to initalize by default,
> otherwise port->socket_id will be probed to wrong value.
>
> Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Thanks!
Patch is fine. Could you add Fixes line for this patch?
I think should be this commit?
commit 999b2ee0fe4511c44462b29566f264e8d9326e1b
Author: Bruce Richardson <bruce.richardson@intel.com>
Date: Fri Mar 24 17:00:38 2017 +0000
app/testpmd: enable NUMA support by default
There is little reason for NUMA support in testpmd to be off by default, so
enable it, and add in a new commandline parameter to disable it, if that is
wanted by users.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
next parent reply other threads:[~2017-04-28 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1493018159-6882-1-git-send-email-yulong.pei@intel.com>
2017-04-28 7:36 ` Wu, Jingjing [this message]
2017-04-28 8:11 ` Pei, Yulong
2017-04-26 4:31 Yulong Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D59D9A@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yulong.pei@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).