From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add check for ethertype filter
Date: Fri, 28 Apr 2017 08:05:12 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D59FCA@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1493290938-80198-1-git-send-email-beilei.xing@intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, April 27, 2017 7:02 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/i40e: add check for ethertype filter
>
> LLDP rule is not supported in ethertype filter.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 1 +
> lib/librte_net/rte_ether.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 0a0181f..24e1c65 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -608,6 +608,7 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev
> *dev,
>
> if (filter->ether_type == ETHER_TYPE_IPv4 ||
> filter->ether_type == ETHER_TYPE_IPv6 ||
> + filter->ether_type == ETHER_TYPE_LLDP ||
> filter->ether_type == outer_tpid) {
> rte_flow_error_set(error, EINVAL,
>
> RTE_FLOW_ERROR_TYPE_ITEM,
> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index
> ff3d065..c448bf3 100644
> --- a/lib/librte_net/rte_ether.h
> +++ b/lib/librte_net/rte_ether.h
> @@ -333,6 +333,7 @@ struct vxlan_hdr {
> #define ETHER_TYPE_1588 0x88F7 /**< IEEE 802.1AS 1588 Precise Time
> Protocol. */ #define ETHER_TYPE_SLOW 0x8809 /**< Slow protocols (LACP
> and Marker). */ #define ETHER_TYPE_TEB 0x6558 /**< Transparent Ethernet
> Bridging. */
> +#define ETHER_TYPE_LLDP 0x88CC /**< LLDP Protocol. */
>
> #define ETHER_VXLAN_HLEN (sizeof(struct udp_hdr) + sizeof(struct vxlan_hdr))
> /**< VXLAN tunnel header length. */
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> --
> 2.5.5
next prev parent reply other threads:[~2017-04-28 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 11:02 Beilei Xing
2017-04-28 8:05 ` Wu, Jingjing [this message]
2017-05-05 15:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D59FCA@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).