From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Zang MingJie <zealot0630@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
Date: Sat, 9 Sep 2017 03:21:32 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E43C98@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170824132909.31253-1-zealot0630@gmail.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zang MingJie
> Sent: Thursday, August 24, 2017 9:29 PM
> To: dev@dpdk.org
> Cc: Zang MingJie <zealot0630@gmail.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
>
> Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf.
> The patch should fix the problem.
>
> Signed-off-by: Zang MingJie <zealot0630@gmail.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 5f26e24a3..cd48ebbc1 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi, bool on)
> }
>
> if (on)
> - vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH;
> + vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR;
> else
> vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_NOTHING;
> vsi->info.valid_sections =
How did you find this issue? In our cases, it works well.
And according to the datasheet, the EMOD_STR meaning Hide vlan but not strip them to descriptor.
Thanks
Jingjing
next prev parent reply other threads:[~2017-09-09 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 13:29 Zang MingJie
2017-09-09 3:21 ` Wu, Jingjing [this message]
2017-10-11 5:12 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E43C98@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=zealot0630@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).