From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "Dai, Wei" <wei.dai@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Dai, Wei" <wei.dai@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped
Date: Wed, 13 Sep 2017 07:32:53 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E48C44@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013201ACB7@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Monday, September 11, 2017 10:46 AM
> To: Dai, Wei <wei.dai@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is
> stopped
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai
> > Sent: Monday, September 11, 2017 10:12 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when
> > port is stopped
> >
> > When an i40e PF port is stopped, all mirror rules should be removed.
> > All rule related software and hardware resources should also be removed.
> >
> > Fixes: a4def5edf0fc ("i40e: enable port mirroring")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > Tested-by: Lijuan Tu <lijuanx.a.tu@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 18 +++++++++++++++---
> > 1 file changed, 15 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 5f26e24..a278748 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -2094,10 +2094,22 @@ i40e_dev_stop(struct rte_eth_dev *dev)
> >
> > /* Remove all mirror rules */
> > while ((p_mirror = TAILQ_FIRST(&pf->mirror_list))) {
> > - TAILQ_REMOVE(&pf->mirror_list, p_mirror, rules);
> > - rte_free(p_mirror);
> > + int ret;
> > + ret = i40e_aq_del_mirror_rule(hw, pf->main_vsi->veb->seid,
> > + p_mirror->rule_type,
> > + p_mirror->entries,
> > + p_mirror->num_entries,
> > + p_mirror->id);
> > + if (ret < 0) {
> > + PMD_DRV_LOG(ERR, "failed to remove mirror rule: "
> > + "status = %d, aq_err = %d.", ret,
> > + hw->aq.asq_last_status);
> > + } else {
> > + TAILQ_REMOVE(&pf->mirror_list, p_mirror, rules);
> > + rte_free(p_mirror);
> > + pf->nb_mirror_rule--;
> > + }
>
> little comment: else statement can be omitted here.
>
Another minor coding style comment:
Do not use braces (``{`` and ``}``) for control statements with zero or just a single statement, unless that statement is more than a single line in which case the braces are permitted.
> > }
> > - pf->nb_mirror_rule = 0;
> >
> > if (!rte_intr_allow_others(intr_handle))
> > /* resume to the default handler */
> > --
> > 2.7.5
next prev parent reply other threads:[~2017-09-13 7:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 14:52 [dpdk-stable] [PATCH] " Wei Dai
2017-09-07 7:34 ` Dai, Wei
2017-09-07 7:35 ` Dai, Wei
2017-09-07 7:37 ` Tu, LijuanX A
2017-09-07 7:50 ` Wu, Jingjing
2017-09-07 9:22 ` Dai, Wei
2017-09-11 2:10 ` [dpdk-stable] [PATCH v2] " Wei Dai
2017-09-11 2:11 ` Wei Dai
2017-09-11 2:45 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2017-09-13 7:32 ` Wu, Jingjing [this message]
2017-09-19 2:21 ` Wu, Jingjing
2017-09-20 1:44 ` Dai, Wei
2017-09-11 2:30 ` [dpdk-stable] " Wei Dai
2017-09-20 1:59 ` [dpdk-stable] [PATCH v3] " Wei Dai
2017-09-20 2:12 ` [dpdk-stable] [PATCH v4] " Wei Dai
2017-09-20 4:16 ` [dpdk-stable] [PATCH v5] " Wei Dai
2017-09-20 9:23 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2017-09-20 14:26 ` Dai, Wei
2017-09-20 22:46 ` Ananyev, Konstantin
2017-09-23 2:26 ` Wu, Jingjing
2017-09-23 10:37 ` Ananyev, Konstantin
2017-09-23 16:34 ` Dai, Wei
2017-09-25 6:36 ` [dpdk-stable] [PATCH v6] net/i40e: fix mirror rule reset when port is closed Wei Dai
2017-09-26 13:49 ` Wu, Jingjing
2017-09-28 15:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E48C44@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).