From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix uninitialized variable
Date: Tue, 26 Sep 2017 13:56:29 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E801DC@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1506064695-31920-1-git-send-email-wang.yong19@zte.com.cn>
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Friday, September 22, 2017 3:18 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [PATCH] net/i40e: fix uninitialized variable
>
> In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
> func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index 73c315a..3c0f436 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2218,6 +2218,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_device
> *pci_dev)
> new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
> new_link.link_status = vf->link_up ? ETH_LINK_UP :
> ETH_LINK_DOWN;
> + new_link.link_autoneg = ETH_LINK_AUTONEG;
>
It is right, but it will be better to set it by checking (dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED)?
And if your patch is fixing some issue, please add fixes line in your patch, and Cc: stable@dpdk.org
Thanks
Jingjing
prev parent reply other threads:[~2017-09-26 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 7:18 Yong Wang
2017-09-26 13:56 ` Wu, Jingjing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E801DC@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=wang.yong19@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).