From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH 04/10] net/i40e: fix compilation with -Og
Date: Wed, 11 Oct 2017 06:20:35 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E911C1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <bd0de0a4-0de6-56b0-9bdc-e3252f4e5f77@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, October 6, 2017 7:25 AM
> To: Olivier Matz <olivier.matz@6wind.com>; dev@dpdk.org; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 04/10] net/i40e: fix compilation with -Og
>
> On 9/11/2017 4:13 PM, Olivier Matz wrote:
> > The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the
> > following
> > error:
> >
> > CC i40e_adminq.o
> > i40e_adminq.c: In function ‘i40e_clean_arq_element’:
> > i40e_adminq.c:1145:56: error: ‘ntu’ may be used uninitialized in
> > this function [-Werror=maybe-uninitialized]
> > *pending = (ntc > ntu ? hw->aq.arq.count : 0) + (ntu - ntc);
> > ~~~~~^~~~~~
> >
> > Depending on what is defined, ntu actually be used without being
> > initialized. Fix it by initializing it to 0, despite this is probably
> > not the proper fix. Moreover, the error is located in base/ directory,
> > which contains driver code common to several platforms (not only dpdk).
>
> This practically seems false positive because driver makefile hard-coded both
> defines.
>
> Also ntu used before this location, not sure warning generated for here.
>
> Overall I am for fixing the compile warning, but for decision maintainer cc'ed
> because this being base code update requires maintainer communicate other
> channels to reflect update into base code.
>
Right, for base code, we are getting them from internal release.
In principle, based code would keep unchanged until the base code update.
I will go to report this issue to base code develop team, and then make
It be fixed in next base code drop. Is that OK?
Thanks
Jingjing
next prev parent reply other threads:[~2017-10-11 6:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 15:13 [dpdk-dev] [PATCH 00/10] " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 01/10] net/bnxt: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 02/10] net/qede: " Olivier Matz
2017-09-11 18:22 ` Patil, Harish
2017-09-11 15:13 ` [dpdk-dev] [PATCH 03/10] net/virtio: " Olivier Matz
2017-10-05 23:17 ` Ferruh Yigit
2017-10-05 23:28 ` Ferruh Yigit
2017-10-06 6:43 ` Maxime Coquelin
2017-10-06 18:43 ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 04/10] net/i40e: " Olivier Matz
2017-10-05 23:24 ` Ferruh Yigit
2017-10-11 6:20 ` Wu, Jingjing [this message]
2017-10-11 7:52 ` Olivier MATZ
2017-09-11 15:13 ` [dpdk-dev] [PATCH 05/10] uio: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 06/10] cmdline: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 07/10] metrics: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 08/10] lpm6: " Olivier Matz
2017-10-06 0:18 ` Ferruh Yigit
2017-10-26 10:42 ` Bruce Richardson
2017-10-26 18:54 ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 09/10] app/test-crypto-perf: fix memory leak Olivier Matz
2017-10-05 9:29 ` De Lara Guarch, Pablo
2017-09-11 15:13 ` [dpdk-dev] [PATCH 10/10] app/test-crypto-perf: fix compilation with -Og Olivier Matz
2017-10-05 9:36 ` De Lara Guarch, Pablo
2017-09-11 15:28 ` [dpdk-dev] [PATCH 00/10] " Bruce Richardson
2017-10-06 0:26 ` Ferruh Yigit
2017-10-06 7:31 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E911C1@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).