From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Pei, Yulong" <yulong.pei@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 2/3] app/test-pmd: add CLI for shaper and wred profiles
Date: Fri, 13 Oct 2017 02:33:07 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E94668@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20171011092612.13369-2-jasvinder.singh@intel.com>
> +/* *** Add Port TM Node WRED Profile *** */ struct
> +cmd_add_port_tm_node_wred_profile_result {
> + cmdline_fixed_string_t add;
> + cmdline_fixed_string_t port;
> + cmdline_fixed_string_t tm;
> + cmdline_fixed_string_t node;
> + cmdline_fixed_string_t wred;
> + cmdline_fixed_string_t profile;
> + uint16_t port_id;
> + uint32_t wred_profile_id;
> + cmdline_fixed_string_t color_g;
> + uint16_t min_th_g;
> + uint16_t max_th_g;
> + uint16_t maxp_inv_g;
> + uint16_t wq_log2_g;
> + cmdline_fixed_string_t color_y;
> + uint16_t min_th_y;
> + uint16_t max_th_y;
> + uint16_t maxp_inv_y;
> + uint16_t wq_log2_y;
> + cmdline_fixed_string_t color_r;
> + uint16_t min_th_r;
> + uint16_t max_th_r;
> + uint16_t maxp_inv_r;
> + uint16_t wq_log2_r;
> +};
> +
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_add =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result, add,
> "add");
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_port =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result, port,
> "port");
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_tm =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result, tm, "tm");
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_node =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result, node,
> "node");
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_wred =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result, wred,
> "wred");
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_profile
> =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + profile, "profile");
> +cmdline_parse_token_num_t cmd_add_port_tm_node_wred_profile_port_id
> =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + port_id, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_wred_profile_id =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + wred_profile_id, UINT32);
> +cmdline_parse_token_string_t
> cmd_add_port_tm_node_wred_profile_color_g =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + color_g, "G#g");
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_min_th_g =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + min_th_g, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_max_th_g =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + max_th_g, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_maxp_inv_g =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + maxp_inv_g, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_wq_log2_g =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + wq_log2_g, UINT16);
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_color_y
> =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + color_y, "Y#y");
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_min_th_y =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + min_th_y, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_max_th_y =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + max_th_y, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_maxp_inv_y =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + maxp_inv_y, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_wq_log2_y =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + wq_log2_y, UINT16);
> +cmdline_parse_token_string_t cmd_add_port_tm_node_wred_profile_color_r
> =
> + TOKEN_STRING_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + color_r, "R#r");
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_min_th_r =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + min_th_r, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_max_th_r =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + max_th_r, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_maxp_inv_r =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + maxp_inv_r, UINT16);
> +cmdline_parse_token_num_t
> cmd_add_port_tm_node_wred_profile_wq_log2_r =
> + TOKEN_NUM_INITIALIZER(
> + struct cmd_add_port_tm_node_wred_profile_result,
> + wq_log2_r, UINT16);
> +
> +
> +static void cmd_add_port_tm_node_wred_profile_parsed(void *parsed_result,
> + __attribute__((unused)) struct cmdline *cl,
> + __attribute__((unused)) void *data)
> +{
> + struct cmd_add_port_tm_node_wred_profile_result *res =
> parsed_result;
> + struct rte_tm_wred_params wp;
> + enum rte_tm_color color;
> + struct rte_tm_error error;
> + uint32_t wred_profile_id = res->wred_profile_id;
> + portid_t port_id = res->port_id;
> + int ret;
> +
> + if (port_id_is_invalid(port_id, ENABLED_WARN))
> + return;
> +
> + memset(&wp, 0, sizeof(struct rte_tm_wred_params));
> +
> + /* WRED Params (Green Color)*/
> + if ((strcmp(res->color_g, "G") == 0) ||
> + (strcmp(res->color_g, "g") == 0)) {
> + color = RTE_TM_GREEN;
> + wp.red_params[color].min_th = res->min_th_g;
> + wp.red_params[color].max_th = res->max_th_g;
> + wp.red_params[color].maxp_inv = res->maxp_inv_g;
> + wp.red_params[color].wq_log2 = res->wq_log2_g;
> + } else {
> + printf("WRED profile error(G or g for green color)!\n");
> + return;
> + }
> +
No need to check the res->color_g, because it already be checked by cmdline.
Because you defined it like
cmd_add_port_tm_node_wred_profile_color_g =
TOKEN_STRING_INITIALIZER(
struct cmd_add_port_tm_node_wred_profile_result,
color_g, "G#g");
You can just assign wp.red_params[RTE_TM_GREEN] directly.
The similar as color_y, color_r.
And is that possible for you to set WERD with less than 3 colors? If so, you may need
to change your command definition.
Thanks
Jingjing
next prev parent reply other threads:[~2017-10-13 2:33 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:02 [dpdk-dev] [PATCH 1/2] app/testpmd: add traffic management forwarding mode Jasvinder Singh
2017-08-22 17:02 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add CLI for tm mode Jasvinder Singh
2017-09-14 11:53 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: add traffic management forwarding mode Jasvinder Singh
2017-09-14 11:53 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for tm mode Jasvinder Singh
2017-09-18 14:03 ` De Lara Guarch, Pablo
2017-09-19 15:06 ` Singh, Jasvinder
2017-09-18 13:54 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: add traffic management forwarding mode De Lara Guarch, Pablo
2017-09-19 15:04 ` Singh, Jasvinder
2017-09-20 9:56 ` [dpdk-dev] [PATCH v3 1/5] " Jasvinder Singh
2017-09-20 9:56 ` [dpdk-dev] [PATCH v3 2/5] app/test-pmd: add CLI for TM capability and stats Jasvinder Singh
2017-09-20 9:56 ` [dpdk-dev] [PATCH v3 3/5] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-09-20 9:56 ` [dpdk-dev] [PATCH v3 4/5] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-09-20 9:56 ` [dpdk-dev] [PATCH v3 5/5] app/test-pmd: add CLI for TM packet classification Jasvinder Singh
2017-09-22 16:35 ` [dpdk-dev] [PATCH v4 1/5] app/testpmd: add traffic management forwarding mode Jasvinder Singh
2017-09-22 16:35 ` [dpdk-dev] [PATCH v4 2/5] app/test-pmd: add CLI for TM capability and stats Jasvinder Singh
2017-09-29 12:38 ` [dpdk-dev] [PATCH v5 1/3] " Jasvinder Singh
2017-09-29 12:38 ` [dpdk-dev] [PATCH v5 2/3] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-09-29 12:38 ` [dpdk-dev] [PATCH v5 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-10-09 19:07 ` [dpdk-dev] [PATCH v6 1/3] app/test-pmd: add CLI for TM capability and stats Jasvinder Singh
2017-10-09 19:07 ` [dpdk-dev] [PATCH v6 2/3] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-10-09 19:07 ` [dpdk-dev] [PATCH v6 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-10-11 8:40 ` Pei, Yulong
2017-10-11 8:51 ` Singh, Jasvinder
2017-10-11 9:26 ` [dpdk-dev] [PATCH v7 1/3] app/test-pmd: add CLI for TM capability and stats Jasvinder Singh
2017-10-11 9:26 ` [dpdk-dev] [PATCH v7 2/3] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-10-13 2:33 ` Wu, Jingjing [this message]
2017-10-13 8:58 ` Singh, Jasvinder
2017-10-11 9:26 ` [dpdk-dev] [PATCH v7 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-10-13 2:58 ` Wu, Jingjing
2017-10-13 10:50 ` Singh, Jasvinder
2017-10-12 20:55 ` [dpdk-dev] [PATCH v7 1/3] app/test-pmd: add CLI for TM capability and stats Thomas Monjalon
2017-10-13 2:34 ` Wu, Jingjing
2017-10-13 6:22 ` Pei, Yulong
2017-10-13 16:59 ` [dpdk-dev] [PATCH v8 " Jasvinder Singh
2017-10-13 16:59 ` [dpdk-dev] [PATCH v8 2/3] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-10-13 17:00 ` [dpdk-dev] [PATCH v8 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-10-14 10:20 ` [dpdk-dev] [PATCH v9 1/3] app/test-pmd: add CLI for TM capability and stats Jasvinder Singh
2017-10-14 10:20 ` [dpdk-dev] [PATCH v9 2/3] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-10-14 10:20 ` [dpdk-dev] [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-10-16 10:18 ` Wu, Jingjing
2017-10-16 18:18 ` Singh, Jasvinder
2017-10-16 18:55 ` [dpdk-dev] [PATCH v10 1/3] app/test-pmd: add CLI for TM capability and stats Jasvinder Singh
2017-10-16 18:55 ` [dpdk-dev] [PATCH v10 2/3] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-10-16 18:55 ` [dpdk-dev] [PATCH v10 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-10-17 8:44 ` [dpdk-dev] [PATCH v10 1/3] app/test-pmd: add CLI for TM capability and stats Wu, Jingjing
2017-10-20 14:08 ` Dumitrescu, Cristian
2017-09-22 16:35 ` [dpdk-dev] [PATCH v4 3/5] app/test-pmd: add CLI for shaper and wred profiles Jasvinder Singh
2017-09-22 16:35 ` [dpdk-dev] [PATCH v4 4/5] app/test-pmd: add CLI for TM nodes and hierarchy commit Jasvinder Singh
2017-09-22 16:35 ` [dpdk-dev] [PATCH v4 5/5] app/test-pmd: add CLI for TM packet classification Jasvinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E94668@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yulong.pei@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).