From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
"shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>,
Tomasz Duszynski <tdu@semihalf.com>,
Jacek Siuda <jck@semihalf.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean
Date: Tue, 24 Oct 2017 13:38:43 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810EA053D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1985896.boakGMOk3P@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, October 16, 2017 6:46 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Tan, Jianfeng <jianfeng.tan@intel.com>; shreyansh.jain@nxp.com;
> hemant.agrawal@nxp.com; santosh.shukla@caviumnetworks.com; Tomasz Duszynski
> <tdu@semihalf.com>; Jacek Siuda <jck@semihalf.com>;
> jerin.jacob@caviumnetworks.com
> Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean
>
> 16/10/2017 12:29, Wu, Jingjing:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Hi,
> > >
> > > 24/08/2017 04:10, Jingjing Wu:
> > > > } else if (intr_handle->type == RTE_INTR_HANDLE_VDEV) {
> > > > - /* do nothing, and let vdev driver to initialize this struct */
> > > > + /* only check, initialization would be done in vdev driver.*/
> > > > + if (intr_handle->efd_counter_size >
> > > > + sizeof(union rte_intr_read_buffer)) {
> > > > + RTE_LOG(ERR, EAL, "the efd_counter_size is
> oversized");
> > > > + return -EINVAL;
> > > > + }
> > >
> > > How interrupts are working with other buses?
> > >
> > > Is it something we should manage in bus drivers code?
> >
> > Any plan to move interrupts from EAL to bus?
>
> It is an open question :)
OK. How about the patch on current interrupt? I think it is OK, right :)
next prev parent reply other threads:[~2017-10-24 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 8:34 [dpdk-dev] [PATCH] " Jingjing Wu
2017-08-13 15:03 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
2017-08-14 20:06 ` Tan, Jianfeng
2017-08-24 2:10 ` [dpdk-dev] [PATCH v3] " Jingjing Wu
2017-09-04 2:49 ` Tan, Jianfeng
2017-11-07 0:41 ` Thomas Monjalon
2017-10-11 13:11 ` Thomas Monjalon
2017-10-16 10:29 ` Wu, Jingjing
2017-10-16 10:45 ` Thomas Monjalon
2017-10-24 13:38 ` Wu, Jingjing [this message]
2017-10-31 13:25 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810EA053D@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jck@semihalf.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianfeng.tan@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=tdu@semihalf.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).