From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filters
Date: Fri, 30 Jan 2015 08:22:02 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8B87B70@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8972724F843@IRSMSX108.ger.corp.intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, January 28, 2015 10:29 PM
> To: Wu, Jingjing; dev@dpdk.org
> Cc: Cao, Min; Xu, HuilongX
> Subject: RE: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple
> filters
>
>
>
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Thursday, January 22, 2015 7:38 AM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing; De Lara Guarch, Pablo; Cao, Min; Xu, HuilongX
> > Subject: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple
> > filters
> >
> > v2 changes:
> > - remove the code which is already applied in patch "Integrate ethertype
> > filter in igb/ixgbe driver to new API".
> > - modify commands' description in doc testpmd_funcs.rst.
> >
> > The patch set uses filter_ctrl API to replace old 2tuple and 5tuple filter APIs.
> > It defines ntuple filter to combine 2tuple and 5tuple types.
> > It uses new functions and structure to replace old ones in igb/ixgbe
> > driver, new commands to replace old ones in testpmd, and removes the
> old APIs.
> > It removes the filter's index parameters from user interface, only the
> > filter's key and assigned queue are visible to user.
> >
> > Jingjing Wu (6):
> > ethdev: define ntuple filter type and its structure
> > ixgbe: ntuple filter functions replace old ones for 5tuple filter
> > e1000: ntuple filter functions replace old ones for 2tuple and 5tuple
> > filter
> > testpmd: new commands for ntuple filter
> > ethdev: remove old APIs and structures of 5tuple and 2tuple filters
> > doc: commands changed in testpmd_funcs for 2tuple amd 5tuple filter
> >
> > app/test-pmd/cmdline.c | 406 ++++++-------
> > app/test-pmd/config.c | 65 ---
> > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 99 +---
> > lib/librte_ether/rte_eth_ctrl.h | 57 ++
> > lib/librte_ether/rte_ethdev.c | 116 ----
> > lib/librte_ether/rte_ethdev.h | 192 ------
> > lib/librte_pmd_e1000/e1000_ethdev.h | 69 ++-
> > lib/librte_pmd_e1000/igb_ethdev.c | 869 +++++++++++++++++++---
> ---
> > ---
> > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 468 +++++++++++----
> > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 52 +-
> > 10 files changed, 1300 insertions(+), 1093 deletions(-)
> >
> > --
> > 1.9.3
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Just mind that the last patch (changing the documentation) does not apply
> properly, as there was another patch (from you I think), that modifies that
> document.
> Could you send another version of the last patch?
> Not sure if that's OK or if it is better to send the full patchset again.
>
Thank you, Pablo.
Yes. It's due to another patch of doc change is applied before this one.
But I think many patches will update this the document. Let's wait to
see whether there are more comments about this patch set at first.
next prev parent reply other threads:[~2015-01-30 8:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 1:45 [dpdk-dev] [PATCH 0/5] " Jingjing Wu
2015-01-15 1:45 ` [dpdk-dev] [PATCH 1/5] ethdev: define ntuple filter type and its structure Jingjing Wu
2015-01-15 1:45 ` [dpdk-dev] [PATCH 2/5] ixgbe: ntuple filter functions replace old ones for 5tuple filter Jingjing Wu
2015-01-15 1:45 ` [dpdk-dev] [PATCH 3/5] e1000: ntuple filter functions replace old ones for 2tuple and " Jingjing Wu
2015-01-15 1:46 ` [dpdk-dev] [PATCH 4/5] testpmd: new commands for ntuple filter Jingjing Wu
2015-01-15 1:46 ` [dpdk-dev] [PATCH 5/5] ethdev: remove old APIs and structures of 5tuple and 2tuple filters Jingjing Wu
2015-01-21 12:18 ` [dpdk-dev] [PATCH 0/5] new ntuple filter replaces 2tuple and 5tuple filters De Lara Guarch, Pablo
2015-01-22 0:28 ` Wu, Jingjing
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 0/6] " Jingjing Wu
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 1/6] ethdev: define ntuple filter type and its structure Jingjing Wu
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 2/6] ixgbe: ntuple filter functions replace old ones for 5tuple filter Jingjing Wu
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 3/6] e1000: ntuple filter functions replace old ones for 2tuple and " Jingjing Wu
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 4/6] testpmd: new commands for ntuple filter Jingjing Wu
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 5/6] ethdev: remove old APIs and structures of 5tuple and 2tuple filters Jingjing Wu
2015-01-22 7:38 ` [dpdk-dev] [PATCH v2 6/6] doc: commands changed in testpmd_funcs for 2tuple amd 5tuple filter Jingjing Wu
2015-01-28 14:28 ` [dpdk-dev] [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filters De Lara Guarch, Pablo
2015-01-30 8:22 ` Wu, Jingjing [this message]
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 " Jingjing Wu
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 1/6] ethdev: define ntuple filter type and its structure Jingjing Wu
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 2/6] ixgbe: ntuple filter functions replace old ones for 5tuple filter Jingjing Wu
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 3/6] e1000: ntuple filter functions replace old ones for 2tuple and " Jingjing Wu
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 4/6] testpmd: new commands for ntuple filter Jingjing Wu
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 5/6] ethdev: remove old APIs and structures of 5tuple and 2tuple filters Jingjing Wu
2015-02-10 4:48 ` [dpdk-dev] [PATCH v3 6/6] doc: commands changed in testpmd_funcs for 2tuple amd 5tuple filter Jingjing Wu
2015-02-13 2:59 ` [dpdk-dev] [PATCH v3 0/6] new ntuple filter replaces 2tuple and 5tuple filters Xu, HuilongX
2015-02-20 17:29 ` De Lara Guarch, Pablo
2015-02-22 3:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F8B87B70@SHSMSX104.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).