From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs
Date: Sun, 1 Nov 2015 14:33:20 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8D0F1EC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <7872129.vXpfkMljjd@xps13>
Hi, Thomas
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Sunday, November 1, 2015 10:28 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs
>
> 2015-11-01 00:24, Jingjing Wu:
> > This patch extends struct rte_eth_fdir_flow_ext to support flow
> > director in VFs.
> [...]
> > --- a/lib/librte_ether/rte_eth_ctrl.h
> > +++ b/lib/librte_ether/rte_eth_ctrl.h
> > @@ -426,6 +426,8 @@ struct rte_eth_fdir_flow_ext {
> > uint16_t vlan_tci;
> > uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN];
> > /**< It is filled by the flexible payload to match. */
> > + uint8_t is_vf; /**< 1 for VF, 0 for port dev */
> > + uint16_t dst_id; /**< VF ID, available when is_vf is 1*/
> > };
>
> Why adding these parameters in an input struct?
> Shouldn't it be in rte_eth_fdir_action along with rx_queue?
Thanks for your comments. The reason of adding these in input is because this is input but not action.
The patch is to support Flow director works in VF, then direct packets to the rx_queue (belong this vf)
which defined in action, but not direct packets to VF.
Thanks
Jingjing
next prev parent reply other threads:[~2015-11-01 14:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 3:45 [dpdk-dev] [PATCH 0/4] extend flow director to support VF filtering in i40e driver Jingjing Wu
2015-09-22 3:45 ` [dpdk-dev] [PATCH 1/4] ethdev: extend struct to support flow director in VFs Jingjing Wu
2015-10-27 7:52 ` Zhang, Helin
2015-09-22 3:45 ` [dpdk-dev] [PATCH 2/4] i40e: extend flow diretcor to support filtering " Jingjing Wu
2015-10-27 7:52 ` Zhang, Helin
2015-09-22 3:45 ` [dpdk-dev] [PATCH 3/4] testpmd: extend commands Jingjing Wu
2015-10-27 7:53 ` Zhang, Helin
2015-09-22 3:45 ` [dpdk-dev] [PATCH 4/4] doc: extend commands in testpmd and remove related ABI deprecation Jingjing Wu
2015-10-27 7:54 ` Zhang, Helin
2015-10-27 9:35 ` Thomas Monjalon
2015-10-28 2:06 ` Wu, Jingjing
2015-10-28 8:41 ` [dpdk-dev] [PATCH v2 0/4] extend flow director to support VF filtering in i40e driver Jingjing Wu
2015-10-28 8:41 ` [dpdk-dev] [PATCH v2 1/4] ethdev: extend struct to support flow director in VFs Jingjing Wu
2015-10-28 8:41 ` [dpdk-dev] [PATCH v2 2/4] i40e: extend flow diretcor to support filtering " Jingjing Wu
2015-10-28 8:41 ` [dpdk-dev] [PATCH v2 3/4] testpmd: extend commands Jingjing Wu
2015-10-28 8:41 ` [dpdk-dev] [PATCH v2 4/4] doc: extend commands in testpmd and update release note Jingjing Wu
2015-10-30 7:42 ` [dpdk-dev] [PATCH v2 0/4] extend flow director to support VF filtering in i40e driver Zhang, Helin
2015-10-31 16:24 ` [dpdk-dev] [PATCH v3 0/3] " Jingjing Wu
2015-10-31 16:24 ` [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs Jingjing Wu
2015-11-01 14:27 ` Thomas Monjalon
2015-11-01 14:33 ` Wu, Jingjing [this message]
2015-11-01 14:55 ` Thomas Monjalon
2015-11-02 5:24 ` Wu, Jingjing
2015-10-31 16:24 ` [dpdk-dev] [PATCH v3 2/3] i40e: extend flow diretcor to support filtering " Jingjing Wu
2015-11-01 14:28 ` Thomas Monjalon
2015-10-31 16:24 ` [dpdk-dev] [PATCH v3 3/3] testpmd: extend commands Jingjing Wu
2015-11-01 14:45 ` Thomas Monjalon
2015-11-01 14:22 ` [dpdk-dev] [PATCH v3 0/3] extend flow director to support VF filtering in i40e driver Thomas Monjalon
2015-11-04 3:29 ` [dpdk-dev] [PATCH v4 0/3] extend flow drector " Jingjing Wu
2015-11-04 3:29 ` [dpdk-dev] [PATCH v4 1/3] ethdev: extend struct to support flow director in VFs Jingjing Wu
2015-11-04 3:29 ` [dpdk-dev] [PATCH v4 2/3] i40e: extend flow diretcor to support filtering " Jingjing Wu
2015-11-04 3:29 ` [dpdk-dev] [PATCH v4 3/3] testpmd: extend commands Jingjing Wu
2015-11-04 12:41 ` [dpdk-dev] [PATCH v4 0/3] extend flow drector to support VF filtering in i40e driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F8D0F1EC@SHSMSX104.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).