DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Tao, Zhe" <zhe.tao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/dpdk_qat: Fix RX queue start number to	the one just received the packets
Date: Fri, 4 Mar 2016 08:19:18 +0000	[thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8DCE1BC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1443524879-24865-1-git-send-email-zhe.tao@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhe Tao
> Sent: Tuesday, September 29, 2015 7:08 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] examples/dpdk_qat: Fix RX queue start
> number to the one just received the packets
> 
> Every time we started to receive the packets, the start queue number should
> be the one that just received the packets, should not start from zero!
> 
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> ---
>  examples/dpdk_qat/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/dpdk_qat/main.c b/examples/dpdk_qat/main.c index
> dc68989..b818e4e 100644
> --- a/examples/dpdk_qat/main.c
> +++ b/examples/dpdk_qat/main.c
> @@ -187,7 +187,7 @@ nic_rx_get_packet(struct lcore_conf *qconf)
>  		uint32_t i;
> 
>  		qconf->rx_mbuf_pos = 0;
> -		for (i = 0; i < qconf->n_rx_queue; i++) {
> +		for (i = qconf->rx_curr_queue; i < qconf->n_rx_queue; i++) {
>  			qconf->rx_mbuf.len = rte_eth_rx_burst(
>  				qconf->rx_queue_list[qconf-
> >rx_curr_queue].port_id,
>  				qconf->rx_queue_list[qconf-
> >rx_curr_queue].queue_id,

I don't think we need to change the start queue number from 0 to rx_curr_queue.
If changes to start from rx_curr_queue, the queue whose id is less than rx_curr_queue
won't be scanned until this function is called next time.
> --
> 1.9.3

      parent reply	other threads:[~2016-03-04  8:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 11:07 Zhe Tao
2015-12-07  1:32 ` Thomas Monjalon
2015-12-07  8:47   ` Declan Doherty
2016-03-04  8:19 ` Wu, Jingjing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BB6961774997848B5B42BEC655768F8DCE1BC@SHSMSX104.ccr.corp.intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=zhe.tao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).