From: "Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each section in rte_cfgfile_close
Date: Thu, 18 Jun 2015 13:08:37 +0000 [thread overview]
Message-ID: <9CC680510C0AC140A846FED2EF7F96281383DF1C@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <4427464.uLsMqpVbGa@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, June 18, 2015 2:30 PM
> To: Wodkowski, PawelX
> Cc: dev@dpdk.org; Gajdzica, MaciejX T
> Subject: Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each section
> in rte_cfgfile_close
>
> 2015-06-17 16:48, Maciej Gajdzica:
> > From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> >
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
>
> What is fixed exactly? What was the problem?
I will merge this patch with 6th patch in the series. Freeing memory is changed because structure
that is freed changed and this change belongs to next patch in the series.
>
> > @@ -60,6 +60,15 @@ struct rte_cfgfile {
> > * for new entries do we add in */
> > #define CFG_ALLOC_ENTRY_BATCH 16
> >
> > +/* Helpers */
> > +
> > +#define _skip_spaceses(str) ({ \
> > + __typeof__(str) p = (str); \
> > + while (isspace(*p)) \
> > + p++; \
> > + p; \
> > +})
>
> This macro is not used in this patch nor related.
> Is "spaceses" a typo?
Yes it's a typo, thanks.
>
> > @@ -523,7 +530,7 @@ const char *
> > rte_cfgfile_get_entry(struct rte_cfgfile *cfg, const char *sectionname,
> > const char *entryname)
> > {
> > - int i;
> > + size_t i;
>
> Why this change? seems not related to free.
>
num_entries and num_sections variables changed type from int to size_t and now comparison with
i produces warning when compiling.
next prev parent reply other threads:[~2015-06-18 13:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 14:48 [dpdk-dev] [PATCH v2 0/6] cfgfile: config file parsing extension Maciej Gajdzica
2015-06-17 14:48 ` [dpdk-dev] [PATCH v2 1/6] librte_cfgfile: fix code formating in header file Maciej Gajdzica
2015-06-17 14:48 ` [dpdk-dev] [PATCH v2 2/6] librte_compat: fix macro definition Maciej Gajdzica
2015-06-17 14:48 ` [dpdk-dev] [PATCH v2 3/6] cfgfile: split rte_cfgfile_load to smaller functions Maciej Gajdzica
2015-06-17 14:48 ` [dpdk-dev] [PATCH v2 4/6] cfgfile: added line continue character '\' to make multiline values possible Maciej Gajdzica
2015-06-17 14:48 ` [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each section in rte_cfgfile_close Maciej Gajdzica
2015-06-18 12:29 ` Thomas Monjalon
2015-06-18 13:08 ` Gajdzica, MaciejX T [this message]
2015-06-17 14:48 ` [dpdk-dev] [PATCH v2 6/6] cfgfile: added new implementation of section parsing Maciej Gajdzica
2015-06-18 12:37 ` Thomas Monjalon
2015-06-18 13:09 ` Gajdzica, MaciejX T
2015-06-17 16:51 ` [dpdk-dev] [PATCH v2 0/6] cfgfile: config file parsing extension Dumitrescu, Cristian
2015-06-18 12:44 ` Thomas Monjalon
2015-06-22 14:58 ` Gajdzica, MaciejX T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9CC680510C0AC140A846FED2EF7F96281383DF1C@IRSMSX102.ger.corp.intel.com \
--to=maciejx.t.gajdzica@intel.com \
--cc=dev@dpdk.org \
--cc=pawelx.wodkowski@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).