From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device
Date: Thu, 12 Jul 2018 20:39:16 +0000 [thread overview]
Message-ID: <9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com> (raw)
In-Reply-To: <20180711212154.5807-1-mattias.ronnblom@ericsson.com>
> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:
>
> This is the Distributed Software (DSW) event device, which distributes
> the task of scheduling events among all the eventdev ports and their
> lcore threads.
>
> DSW is primarily designed for atomic-only queues, but also supports
> single-link and parallel queues.
>
> (DSW would be more accurately described as 'parallel', but since that
> term is used to describe an eventdev queue type, it's referred to as
> 'distributed', to avoid suggesting it's somehow biased toward parallel
> queues.)
>
>
Just a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.
As for the RFC I like the idea of this RFC, but need to dig into the code.
Thanks
> Short-term TODO
> ===============
>
> o Figure out which DSW parameters needs to be runtime configurable.
> o Consider adding support for event priority.
> o Add relevant test cases to eventdev unit tests.
> o Convert this massive cover letter into proper DPDK documentation.
>
> [1] http://www.lysator.liu.se/~hofors/dsw/migration-sequence.svg
>
> Mattias Rönnblom (1):
> eventdev: add distributed software (DSW) event device
>
> config/common_base | 5 +
> drivers/event/Makefile | 1 +
> drivers/event/dsw/Makefile | 28 +
> drivers/event/dsw/dsw_evdev.c | 361 +++++
> drivers/event/dsw/dsw_evdev.h | 296 ++++
> drivers/event/dsw/dsw_event.c | 1285 +++++++++++++++++
> drivers/event/dsw/dsw_sort.h | 47 +
> drivers/event/dsw/dsw_xstats.c | 284 ++++
> .../event/dsw/rte_pmd_evdev_dsw_version.map | 3 +
> mk/rte.app.mk | 1 +
> 10 files changed, 2311 insertions(+)
> create mode 100644 drivers/event/dsw/Makefile
> create mode 100644 drivers/event/dsw/dsw_evdev.c
> create mode 100644 drivers/event/dsw/dsw_evdev.h
> create mode 100644 drivers/event/dsw/dsw_event.c
> create mode 100644 drivers/event/dsw/dsw_sort.h
> create mode 100644 drivers/event/dsw/dsw_xstats.c
> create mode 100644 drivers/event/dsw/rte_pmd_evdev_dsw_version.map
>
> --
> 2.17.1
>
Regards,
Keith
next prev parent reply other threads:[~2018-07-12 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 21:21 Mattias Rönnblom
2018-07-11 21:21 ` [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device Mattias Rönnblom
2018-07-12 20:39 ` Wiles, Keith [this message]
2018-07-13 17:21 ` [dpdk-dev] [RFC 0/1] A Distributed Software Event Device Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com \
--to=keith.wiles@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=mattias.ronnblom@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).