DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chen, Zhaoyan" <zhaoyan.chen@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/test: reworks the crypto AES unit test
Date: Tue, 21 Jun 2016 02:57:13 +0000	[thread overview]
Message-ID: <9DEEADBC57E43F4DA73B571777FECECA046F11DB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C961AA3@IRSMSX108.ger.corp.intel.com>

Tested-by: Chen, Zhaoyan<zhaoyan.chen@intel.com>

* Commit: 3901ed99c2f82d3e979bb1bea001d61898241829
* Patch Apply: Success
* Compilation: Success
* Kernel/OS: 3.11.10-301.fc20.x86_64
* GCC: 4.8.3 20140911

* Case 1
./app/test -cf -n4
cryptodev_aesni_mb_autotest

Checked the AES-128-CBC / HMAC-224/384 unit test is added. 

* Case 2
./app/test -cf -n4
crypto_qat_autotest
cryptodev_aesni_gcm_autotest
cryptodev_aesni_mb_perftest
cryptodev_qat_perftest
cryptodev_null_autotest

Checked all cryptodev unit tests run smoothly.

Thanks,
Joey


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Wednesday, June 15, 2016 6:41 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/test: reworks the crypto AES
> unit test
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> > Sent: Tuesday, June 14, 2016 10:57 AM
> > To: dev@dpdk.org
> > Cc: Doherty, Declan
> > Subject: [dpdk-dev] [PATCH v5 1/2] app/test: reworks the crypto AES
> > unit test
> >
> > This patch reworks the crypto AES unit test by introducing a new
> > unified test function
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> >  app/test/Makefile                              |    1 +
> >  app/test/test_cryptodev.c                      | 1613 ++----------------------
> >  app/test/test_cryptodev_aes.c                  |  663 ++++++++++
> >  app/test/test_cryptodev_aes.h                  |  828 ++++++++++++
> >  app/test/test_cryptodev_aes_ctr_test_vectors.h |  257 ----
> >  5 files changed, 1614 insertions(+), 1748 deletions(-)  create mode
> > 100644 app/test/test_cryptodev_aes.c  create mode 100644
> > app/test/test_cryptodev_aes.h  delete mode 100644
> > app/test/test_cryptodev_aes_ctr_test_vectors.h
> >
> 
> [...]
> 
> > diff --git a/app/test/test_cryptodev_aes.c
> > b/app/test/test_cryptodev_aes.c new file mode 100644 index
> > 0000000..8c43441
> > --- /dev/null
> > +++ b/app/test/test_cryptodev_aes.c
> > @@ -0,0 +1,663 @@
> > +/*-
> > + *   BSD LICENSE
> > + *
> > + *   Copyright(c) 2015-2016 Intel Corporation. All rights reserved.
> > + *
> > + *   Redistribution and use in source and binary forms, with or without
> > + *   modification, are permitted provided that the following conditions
> > + *   are met:
> > + *
> > + *	 * Redistributions of source code must retain the above copyright
> > + *	   notice, this list of conditions and the following disclaimer.
> > + *	 * Redistributions in binary form must reproduce the above copyright
> > + *	   notice, this list of conditions and the following disclaimer in
> > + *	   the documentation and/or other materials provided with the
> > + *	   distribution.
> > + *	 * Neither the name of Intel Corporation nor the names of its
> > + *	   contributors may be used to endorse or promote products derived
> > + *	   from this software without specific prior written permission.
> > + *
> > + *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> > CONTRIBUTORS
> > + *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
> > NOT
> > + *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> > FITNESS FOR
> > + *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > COPYRIGHT
> > + *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > INCIDENTAL,
> > + *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> BUT
> > NOT
> > + *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> LOSS
> > OF USE,
> > + *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> > AND ON ANY
> > + *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> > TORT
> > + *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
> OF
> > THE USE
> > + *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> > DAMAGE.
> > + */
> > +
> > +#include <rte_common.h>
> > +#include <rte_hexdump.h>
> > +#include <rte_mbuf.h>
> > +#include <rte_malloc.h>
> > +#include <rte_memcpy.h>
> > +
> > +#include <rte_crypto.h>
> > +#include <rte_cryptodev.h>
> > +#include <rte_cryptodev_pmd.h>
> > +
> > +#include "test.h"
> > +#include "test_cryptodev_aes.h"
> > +
> > +#ifndef MAX_N_AES_TESTS
> > +#define MAX_N_AES_TESTS			256
> > +#endif
> 
> This macro is not used anywhere.
> 
> > +
> > +#ifndef AES_TEST_MSG_LEN
> > +#define AES_TEST_MSG_LEN		256
> > +#endif
> > +
> > +#define AES_TEST_OP_ENCRYPT		0x01
> > +#define AES_TEST_OP_DECRYPT		0x02
> > +#define AES_TEST_OP_AUTH_GEN		0x04
> > +#define AES_TEST_OP_AUTH_VERIFY		0x08

  reply	other threads:[~2016-06-21  2:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  9:09 [dpdk-dev] [PATCH 0/5] app/test: rework " Fan Zhang
2016-05-31  9:09 ` [dpdk-dev] [PATCH 1/5] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-05-31  9:09 ` [dpdk-dev] [PATCH 2/5] app/test: add unified crypto aes test Fan Zhang
2016-06-07 20:00   ` Thomas Monjalon
2016-05-31  9:09 ` [dpdk-dev] [PATCH 3/5] app/test: utilize new unified crypto AES test function Fan Zhang
2016-05-31  9:09 ` [dpdk-dev] [PATCH 4/5] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-05-31  9:09 ` [dpdk-dev] [PATCH 5/5] examples/l2fwd-crypto: enable AES counter mode cipher algorithm Fan Zhang
2016-06-07 20:03 ` [dpdk-dev] [PATCH 0/5] app/test: rework crypto AES unit test Thomas Monjalon
2016-06-08 15:38 ` [dpdk-dev] [PATCH v2 0/4] " Fan Zhang
2016-06-08 15:38   ` [dpdk-dev] [PATCH v2 1/4] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-06-08 15:38   ` [dpdk-dev] [PATCH v2 2/4] app/test: add unified crypto aes test Fan Zhang
2016-06-08 15:38   ` [dpdk-dev] [PATCH v2 3/4] app/test: utilize new unified crypto AES test function Fan Zhang
2016-06-08 15:38   ` [dpdk-dev] [PATCH v2 4/4] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-13 12:53   ` [dpdk-dev] [PATCH v3 0/4] app/test: rework crypto AES unit test Fan Zhang
2016-06-13 12:53     ` [dpdk-dev] [PATCH v3 1/4] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-06-13 12:53     ` [dpdk-dev] [PATCH v3 2/4] app/test: add unified crypto aes test Fan Zhang
2016-06-13 12:53     ` [dpdk-dev] [PATCH v3 3/4] app/test: utilize new unified crypto AES test function Fan Zhang
2016-06-13 12:53     ` [dpdk-dev] [PATCH v3 4/4] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-13 14:08     ` [dpdk-dev] [PATCH v4 0/4] app/test: rework crypto AES unit test Fan Zhang
2016-06-13 14:08       ` [dpdk-dev] [PATCH v4 1/4] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-06-13 14:08       ` [dpdk-dev] [PATCH v4 2/4] app/test: add unified crypto aes test Fan Zhang
2016-06-13 14:08       ` [dpdk-dev] [PATCH v4 3/4] app/test: utilize new unified crypto AES test function Fan Zhang
2016-06-13 14:08       ` [dpdk-dev] [PATCH v4 4/4] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-13 20:26       ` [dpdk-dev] [PATCH v4 0/4] app/test: rework crypto AES unit test Thomas Monjalon
2016-06-14  9:57       ` [dpdk-dev] [PATCH v5 0/2] " Fan Zhang
2016-06-14  9:57         ` [dpdk-dev] [PATCH v5 1/2] app/test: reworks the " Fan Zhang
2016-06-15 10:41           ` De Lara Guarch, Pablo
2016-06-21  2:57             ` Chen, Zhaoyan [this message]
2016-06-14  9:57         ` [dpdk-dev] [PATCH v5 2/2] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-15 11:02         ` [dpdk-dev] [PATCH v6 0/2] rework crypto AES unit test Fan Zhang
2016-06-15 11:02           ` [dpdk-dev] [PATCH v6 1/2] app/test: rework the " Fan Zhang
2016-06-15 11:02           ` [dpdk-dev] [PATCH v6 2/2] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-15 12:50           ` [dpdk-dev] [PATCH v6 0/2] rework crypto AES unit test De Lara Guarch, Pablo
2016-06-20 15:18             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9DEEADBC57E43F4DA73B571777FECECA046F11DB@shsmsx102.ccr.corp.intel.com \
    --to=zhaoyan.chen@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).