From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/3] port: code clean-up
Date: Fri, 1 Apr 2016 14:06:24 +0000 [thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C60409D3567D@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <2420426.ojDceOkhvu@xps13>
Hi Thomas,
The reason for removing RTE_NEXT_ABI here is caused by sink port, which is not wrapped by RTE_NEXT_ABI macro.
If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original code will cause the compile error as pcap library is missing.
Regards,
Fan
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Friday, April 1, 2016 2:56 PM
To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] port: code clean-up
2016-04-01 14:41, Fan Zhang:
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -92,9 +92,7 @@ endif
> ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)
> _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse
> endif
> -ifeq ($(CONFIG_RTE_NEXT_ABI),y)
> _LDLIBS-$(CONFIG_RTE_PORT_PCAP) += -lpcap
> -endif
Why removing NEXT_ABI here?
The pcap port cannot work without it because of
+#ifdef RTE_NEXT_ABI
+
+ /** The full path of the pcap file to read packets from */
+ char *file_name;
+ /** The number of bytes to be read from each packet in the
+ * pcap file. If this value is 0, the whole packet is read;
+ * if it is bigger than packet size, the generated packets
+ * will contain the whole packet */
+ uint32_t n_bytes_per_pkt;
+
+#endif
next prev parent reply other threads:[~2016-04-01 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 13:41 [dpdk-dev] [PATCH 0/3] bug fix and " Fan Zhang
2016-04-01 13:41 ` [dpdk-dev] [PATCH 1/3] port: fix source port parameter check Fan Zhang
2016-04-01 13:41 ` [dpdk-dev] [PATCH 2/3] port: fix sink " Fan Zhang
2016-04-01 13:41 ` [dpdk-dev] [PATCH 3/3] port: code clean-up Fan Zhang
2016-04-01 13:56 ` Thomas Monjalon
2016-04-01 14:04 ` Zhang, Roy Fan
2016-04-01 14:06 ` Zhang, Roy Fan [this message]
2016-04-01 20:53 ` [dpdk-dev] [PATCH 0/3] bug fix and " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F7182E3F746AB4EA17801C148F3C60409D3567D@IRSMSX101.ger.corp.intel.com \
--to=roy.fan.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).