From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "zbigniew.bodek@caviumnetworks.com"
<zbigniew.bodek@caviumnetworks.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] drvers/crypto: do not create unique name internally
Date: Wed, 19 Apr 2017 10:05:45 +0000 [thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C60409E9A8C5@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1492526060-96427-2-git-send-email-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, April 18, 2017 3:34 PM
> To: dev@dpdk.org
> Cc: zbigniew.bodek@caviumnetworks.com;
> jerin.jacob@caviumnetworks.com; Doherty, Declan
> <declan.doherty@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH 2/2] drvers/crypto: do not create unique name internally
>
> Crypto devices of the same type could be initialized with the same name,
> since internally this name was suffixed with an index.
>
> Since commit <dda987315ca2> ("vdev: make virtual bus use its device struct"),
> this is not allowed anymore.
>
> Therefore, there is no need to create an unique name at device initialization.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Hi Pablo,
Typo in the title :-), should be drivers/crypto instead of drvers/crypto. Apart from that, everything is fine by me.
Regards,
Fan
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
next prev parent reply other threads:[~2017-04-19 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 14:34 [dpdk-dev] [PATCH 1/2] drivers/crypto: check if name is NULL Pablo de Lara
2017-04-18 14:34 ` [dpdk-dev] [PATCH 2/2] drvers/crypto: do not create unique name internally Pablo de Lara
2017-04-19 10:05 ` Zhang, Roy Fan [this message]
2017-04-19 15:55 ` De Lara Guarch, Pablo
2017-04-19 9:48 ` [dpdk-dev] [PATCH 1/2] drivers/crypto: check if name is NULL Zhang, Roy Fan
2017-04-19 15:55 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F7182E3F746AB4EA17801C148F3C60409E9A8C5@IRSMSX101.ger.corp.intel.com \
--to=roy.fan.zhang@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=zbigniew.bodek@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).