From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: 'Jay Zhou' <jianjay.zhou@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"arei.gonglei@huawei.com" <arei.gonglei@huawei.com>,
"Zeng, Xin" <xin.zeng@intel.com>,
"weidong.huang@huawei.com" <weidong.huang@huawei.com>,
"wangxinxin.wang@huawei.com" <wangxinxin.wang@huawei.com>,
"longpeng2@huawei.com" <longpeng2@huawei.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices
Date: Wed, 21 Mar 2018 04:08:51 +0000 [thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C604331024B8@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <02e4c16f6c0f330f8c7941160a69e8d20510713f.1519477564.git.jianjay.zhou@huawei.com>
Hi Jay,
Excellent work! The patch, although need some minor rework, has improved the performance.
Some comments:
1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost crypto proxy backend only AESCBC and SHA1 are supported (in cryptodev_vhost_user_init() definition), I believe in this version these two algorithms shall be enough. Actually for the same reason I suggest you to remove all AES_CTR test cases in the virtio_crypto PMD functional test, as they will fail when vhost_user crypto backend is used.
You may use driver/crypto/qat/qat_crypto_capabilities.h as example. The const capabilities array shall be returned to the application when virtio_crypto_dev_info_get() is called.
2. there is a bug in virtio_crypto_queue_setup(), you declared " uint32_t i, j;" while i may be used uninitialized later.
Regards,
Fan
> diff --git a/drivers/crypto/virtio/virtio_rxtx.c
> b/drivers/crypto/virtio/virtio_rxtx.c
> new file mode 100644
> index 0000000..b7d8066
> --- /dev/null
> +++ b/drivers/crypto/virtio/virtio_rxtx.c
> @@ -0,0 +1,533 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD.
> + */
> +
next prev parent reply other threads:[~2018-03-21 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 13:14 [dpdk-dev] [PATCH v2 0/7] crypto: add virtio poll mode driver Jay Zhou
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 1/7] crypto/virtio: add virtio related fundamental functions Jay Zhou
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 2/7] crpyto/virtio: add crypto related session structure Jay Zhou
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices Jay Zhou
2018-03-21 4:08 ` Zhang, Roy Fan [this message]
2018-03-21 4:58 ` Zhoujian (jay)
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 4/7] crypto/virtio: add makefile Jay Zhou
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 5/7] cryptodev: add document for virtio crypto PMD Jay Zhou
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 6/7] cryptodev: add function tests " Jay Zhou
2018-02-24 13:14 ` [dpdk-dev] [PATCH v2 7/7] MAINTAINERS: add myself as virtio crypto PMD maintainer Jay Zhou
2018-03-21 1:44 ` [dpdk-dev] [PATCH v2 0/7] crypto: add virtio poll mode driver Zhoujian (jay)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F7182E3F746AB4EA17801C148F3C604331024B8@IRSMSX101.ger.corp.intel.com \
--to=roy.fan.zhang@intel.com \
--cc=arei.gonglei@huawei.com \
--cc=dev@dpdk.org \
--cc=jianjay.zhou@huawei.com \
--cc=longpeng2@huawei.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).