From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile
Date: Tue, 17 Apr 2018 08:56:39 +0000 [thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C6043311CCA3@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <8063790.J3il9MjH7d@xps>
Hi Thomas,
In fact Meson compile enables all library builds so you cannot turn off cryptodev
manually. So the condition checking to disable vhost crypto build is not necessary.
Regards,
Fan
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, April 16, 2018 10:43 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; shahafs@mellanox.com;
> Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile
>
> 16/04/2018 16:08, Fan Zhang:
> > Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
> >
> > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
> > This patch fix this by adding checking to Makefile.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> > lib/librte_vhost/Makefile | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
>
> What about meson.build?
>
>
next prev parent reply other threads:[~2018-04-17 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 14:08 Fan Zhang
2018-04-16 21:42 ` Thomas Monjalon
2018-04-17 8:56 ` Zhang, Roy Fan [this message]
2018-04-17 8:57 ` Bruce Richardson
2018-04-17 10:12 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2018-04-09 16:38 [dpdk-dev] [PATCH v2] vhost/crypto: fix bugs Fan Zhang
2018-04-09 18:01 ` [dpdk-dev] [PATCH] vhost/crypto: fix makefile Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F7182E3F746AB4EA17801C148F3C6043311CCA3@IRSMSX101.ger.corp.intel.com \
--to=roy.fan.zhang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).