DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Wang, Jie1X" <jie1x.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [PATCH v3 0/5] support flow subscription
Date: Wed, 31 Aug 2022 13:53:36 +0100	[thread overview]
Message-ID: <9a58149a-aafa-4d74-b5a3-27627d283c19@xilinx.com> (raw)
In-Reply-To: <DM4PR11MB599440FD42A9AB693F504B99D7789@DM4PR11MB5994.namprd11.prod.outlook.com>

On 8/31/2022 1:28 PM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@xilinx.com>
>> Sent: Wednesday, August 31, 2022 6:57 PM
>> To: Wang, Jie1X <jie1x.wang@intel.com>; dev@dpdk.org
>> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; Yang, SteveX <stevex.yang@intel.com>
>> Subject: Re: [PATCH v3 0/5] support flow subscription
>>
>> On 8/30/2022 7:05 PM, Jie Wang wrote:
>>> Add support AVF can be able to subscribe a flow from PF.
>>>
>>
>> Hi Jie,
>>
>> Can you please provide more details, what does subscribing a flow from PF
>> mean?
> 
> The answer is in patch 1/5's commit log which would be better in cover letter also :)
> 

Hi Qi,

I checked all commit logs, but the feature wasn't clear to me, it can be 
useful to elaborate more.

Is it the case that:
- PF create a flow rule
- VF subscribes to this rule, which means
   - Packets will be sent to VF instead of PF

If above is correct, will both PF and VF receive packets, or only VF?
Can multiple VF subscribe to same rule?
Can PF destroy the rule while VF is subscribed?
How PF can prevent subscription to some flows from not trusted VF for 
security concern?
...

>>
>> Thanks,
>> ferruh
>>
>>> --
>>> v3:
>>>    * fix eth layer inputset.
>>>    * rebase.
>>> v2:
>>>    * split v1 patch 2/2 to 4 small patches.
>>>    * remove rule action RTE_FLOW_ACTION_TYPE_VF and add
>>>      RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT.
>>>
>>> Jie Wang (5):
>>>     common/iavf: support flow subscription
>>>     net/iavf: add flow subscription to AVF
>>>     net/iavf: support flow subscrption pattern
>>>     net/iavf: support flow subscription rule
>>>     net/iavf: support priority of flow rule
>>>
>>>    doc/guides/rel_notes/release_22_11.rst |   4 +
>>>    drivers/common/iavf/virtchnl.h         | 104 +++-
>>>    drivers/net/iavf/iavf.h                |  13 +
>>>    drivers/net/iavf/iavf_fdir.c           |   4 +
>>>    drivers/net/iavf/iavf_fsub.c           | 745 +++++++++++++++++++++++++
>>>    drivers/net/iavf/iavf_generic_flow.c   |  40 +-
>>>    drivers/net/iavf/iavf_generic_flow.h   |   2 +
>>>    drivers/net/iavf/iavf_hash.c           |   5 +
>>>    drivers/net/iavf/iavf_ipsec_crypto.c   |  16 +-
>>>    drivers/net/iavf/iavf_vchnl.c          | 133 +++++
>>>    drivers/net/iavf/meson.build           |   1 +
>>>    11 files changed, 1046 insertions(+), 21 deletions(-)
>>>    create mode 100644 drivers/net/iavf/iavf_fsub.c
>>>
> 


  reply	other threads:[~2022-08-31 12:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  6:21 [PATCH 0/2] " Jie Wang
2022-08-09  6:21 ` [PATCH 1/2] common/iavf: " Jie Wang
2022-08-09  6:21 ` [PATCH 2/2] net/iavf: enable flow subscription rule support for AVF Jie Wang
2022-08-12 17:04 ` [PATCH v2 0/5] support flow subscription Jie Wang
2022-08-12 17:04   ` [PATCH v2 1/5] common/iavf: " Jie Wang
2022-08-12 17:04   ` [PATCH v2 2/5] net/iavf: add flow subscription to AVF Jie Wang
2022-08-12 17:04   ` [PATCH v2 3/5] net/iavf: support flow subscrption pattern Jie Wang
2022-08-12 17:04   ` [PATCH v2 4/5] net/iavf: support flow subscription rule Jie Wang
2022-08-12 17:04   ` [PATCH v2 5/5] net/iavf: support priority of flow rule Jie Wang
2022-08-30 18:05 ` [PATCH v3 0/5] support flow subscription Jie Wang
2022-08-30 18:05   ` [PATCH v3 1/5] common/iavf: " Jie Wang
2022-08-30 18:05   ` [PATCH v3 2/5] net/iavf: add flow subscription to AVF Jie Wang
2022-08-30 18:05   ` [PATCH v3 3/5] net/iavf: support flow subscrption pattern Jie Wang
2022-09-06  7:30     ` Zhang, Qi Z
2022-08-30 18:05   ` [PATCH v3 4/5] net/iavf: support flow subscription rule Jie Wang
2022-08-30 18:05   ` [PATCH v3 5/5] net/iavf: support priority of flow rule Jie Wang
2022-08-31 10:56   ` [PATCH v3 0/5] support flow subscription Ferruh Yigit
2022-08-31 12:28     ` Zhang, Qi Z
2022-08-31 12:53       ` Ferruh Yigit [this message]
2022-09-01  0:59         ` Zhang, Qi Z
2022-09-07  3:35 ` [PATCH v4 " Jie Wang
2022-09-07  3:35   ` [PATCH v4 1/5] common/iavf: " Jie Wang
2022-09-07  3:35   ` [PATCH v4 2/5] net/iavf: add flow subscription to AVF Jie Wang
2022-09-07  3:35   ` [PATCH v4 3/5] net/iavf: support flow subscrption pattern Jie Wang
2022-09-07  3:35   ` [PATCH v4 4/5] net/iavf: support flow subscription rule Jie Wang
2022-09-07  3:35   ` [PATCH v4 5/5] net/iavf: support priority of flow rule Jie Wang
2022-09-07  4:38 ` [PATCH v4 0/5] support flow subscription Jie Wang
2022-09-07  4:38   ` [PATCH v4 1/5] common/iavf: " Jie Wang
2022-09-07  4:38   ` [PATCH v4 2/5] net/iavf: add flow subscription to AVF Jie Wang
2022-09-07  4:38   ` [PATCH v4 3/5] net/iavf: support flow subscrption pattern Jie Wang
2022-09-07  4:38   ` [PATCH v4 4/5] net/iavf: support flow subscription rule Jie Wang
2022-09-07  4:38   ` [PATCH v4 5/5] net/iavf: support priority of flow rule Jie Wang
2022-09-07  5:10 ` [PATCH v5 0/5] support flow subscription Jie Wang
2022-09-07  5:10   ` [PATCH v5 1/5] common/iavf: " Jie Wang
2022-09-07  5:10   ` [PATCH v5 2/5] net/iavf: add flow subscription to AVF Jie Wang
2022-09-07  5:10   ` [PATCH v5 3/5] net/iavf: support flow subscrption pattern Jie Wang
2022-09-07  5:27     ` Zhang, Qi Z
2022-09-07  5:10   ` [PATCH v5 4/5] net/iavf: support flow subscription rule Jie Wang
2022-09-07  5:10   ` [PATCH v5 5/5] net/iavf: support priority of flow rule Jie Wang
2022-09-07  5:28   ` [PATCH v5 0/5] support flow subscription Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a58149a-aafa-4d74-b5a3-27627d283c19@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jie1x.wang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stevex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).