DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Meunier, Julien (Nokia - FR/Paris-Saclay)" <julien.meunier@nokia.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Zhang,  Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add support of loopback for X540/X550
Date: Mon, 18 Feb 2019 11:20:22 +0000	[thread overview]
Message-ID: <9ac18a16-a3ee-f38c-2e0f-a19127a74d16@nokia.com> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07EB1E9A@PGSMSX103.gar.corp.intel.com>

Hi all,

Sorry for the delay. See my reply inline.

On 12/02/2019 07:37, Zhao1, Wei wrote:
> HI,  Meunier && qi
> 
> Is it possible to add these two function of ixgbe_setup_phy_autoneg_x540 and
> ixgbe_setup_phy_autoneg_x550 in a file out of base folder? We need to avoid
> change code in that, is that right? @qi
> And also, it seems these 2 function do not have much difference,
> can we use one instead of two function?(This point is not so important)

OK, no problem. I had some doubts when I modified these files.
So, I guess it's OK for you to have direct PHY operations (hw->phy.ops. 
[read|write]_reg) in ixgbe_rxtx.c ?


>>    * Start Transmit and Receive Units.
>> @@ -5172,6 +5223,12 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)
>>   	if (dev->data->dev_conf.lpbk_mode != 0) {
>>   		if (hw->mac.type == ixgbe_mac_82599EB)
>>   			ixgbe_setup_loopback_link_82599(hw);
>> +		else if (hw->mac.type == ixgbe_mac_X540)
>> +			ixgbe_setup_loopback_link_x540(hw);
>> +		else if (hw->mac.type == ixgbe_mac_X550 ||
>> +		     hw->mac.type == ixgbe_mac_X550EM_x ||
>> +		     hw->mac.type == ixgbe_mac_X550EM_a)
>> +			ixgbe_setup_loopback_link_x550(hw);
> 
> The same, why do we have 2 branch for x540 and x550?
> 

I just wanted to respect the initial rule: 1 model = 1 function. But I 
can merge them in one function as it's the same mechanism in order to 
setup the loopback.

I will update a new patchset today.

Best regards,
Julien Meunier

  reply	other threads:[~2019-02-18 11:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 16:00 [dpdk-dev] [PATCH] " Julien Meunier
2019-01-07  6:53 ` Zhang, Qi Z
2019-01-07 15:53   ` Meunier, Julien (Nokia - FR/Paris-Saclay)
2019-01-08 10:10     ` Zhao1, Wei
2019-01-08 12:39       ` Zhang, Qi Z
2019-01-08 20:18         ` Meunier, Julien (Nokia - FR/Paris-Saclay)
2019-01-09  1:30         ` Zhao1, Wei
2019-01-07 10:05 ` Zhao1, Wei
2019-01-07 16:04   ` Meunier, Julien (Nokia - FR/Paris-Saclay)
2019-01-08  3:10     ` Zhao1, Wei
2019-02-07 17:30 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: do not start on unsupported loopback mode Julien Meunier
2019-02-07 17:30   ` [dpdk-dev] [PATCH 2/2] net/ixgbe: add support of loopback for X540/X550 Julien Meunier
2019-02-12  6:37     ` Zhao1, Wei
2019-02-18 11:20       ` Meunier, Julien (Nokia - FR/Paris-Saclay) [this message]
2019-02-12  6:36   ` [dpdk-dev] [PATCH 1/2] net/ixgbe: do not start on unsupported loopback mode Zhao1, Wei
2019-02-20 21:05 ` [dpdk-dev] [PATCH v3 " Julien Meunier
2019-02-20 21:05   ` [dpdk-dev] [PATCH v3 2/2] net/ixgbe: add support of loopback for X540/X550 Julien Meunier
2019-02-21  2:30     ` Zhao1, Wei
2019-03-01  7:46       ` Zhang, Qi Z
2019-03-01  7:45   ` [dpdk-dev] [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback mode Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ac18a16-a3ee-f38c-2e0f-a19127a74d16@nokia.com \
    --to=julien.meunier@nokia.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=wei.zhao1@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).