patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Cc: dev@dpdk.org, jianfeng.tan@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak
Date: Thu, 25 Apr 2019 13:47:43 +0100	[thread overview]
Message-ID: <9c061f24-ab40-670d-0b7a-fe331ba8a3f2@intel.com> (raw)
In-Reply-To: <20190425114324.611-2-herakliusz.lipiec@intel.com>

On 25-Apr-19 12:43 PM, Herakliusz Lipiec wrote:
> When sending multiple requests, rte_mp_request_sync
> can succeed sending a few of those requests, but then
> fail on a later one and in the end return with rc=-1.
> The upper layers - e.g. device hotplug - currently
> handles this case as if no messages were sent and no
> memory for response buffers was allocated, which is
> not true. Fixed by always freeing memory buffers on
> failure.
> 
> Bugzilla ID: 228
> Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
> Cc: jianfeng.tan@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  reply	other threads:[~2019-04-25 12:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 14:38 [dpdk-stable] [PATCH 1/8] " Herakliusz Lipiec
2019-04-23  8:11 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-04-23  8:13 ` Burakov, Anatoly
     [not found] ` <20190423174334.19612-1-herakliusz.lipiec@intel.com>
2019-04-23 17:43   ` [dpdk-stable] [PATCH v2 " Herakliusz Lipiec
2019-04-24  9:28     ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-25  9:37     ` Burakov, Anatoly
2019-04-23 17:43   ` [dpdk-stable] [PATCH v2 2/8] ipc: fix hotplug memleak Herakliusz Lipiec
2019-04-25  6:00     ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-stable] [PATCH v2 3/8] ipc: fix vdev memleak Herakliusz Lipiec
2019-04-25  6:08     ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-stable] [PATCH v2 4/8] ipc: fix vfio memleak Herakliusz Lipiec
2019-04-25  6:06     ` [dpdk-stable] [dpdk-dev] " Stojaczyk, Dariusz
2019-04-23 17:43   ` [dpdk-stable] [PATCH v2 5/8] ipc: fix pdump memleak Herakliusz Lipiec
2019-04-23 17:43   ` [dpdk-stable] [PATCH v2 6/8] ipc: fix tap pmd memleak Herakliusz Lipiec
     [not found]   ` <20190425114324.611-1-herakliusz.lipiec@intel.com>
2019-04-25 11:43     ` [dpdk-stable] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:47       ` Burakov, Anatoly [this message]
2019-04-25 11:43     ` [dpdk-stable] [PATCH v3 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
     [not found]     ` <20190425124817.28409-1-herakliusz.lipiec@intel.com>
2019-04-25 12:48       ` [dpdk-stable] [PATCH v4 1/2] ipc: fix rte_mp_request_sync memleak Herakliusz Lipiec
2019-04-25 12:48         ` Burakov, Anatoly
2019-04-25 12:48       ` [dpdk-stable] [PATCH v4 2/2] ipc: fix tap pmd memleak Herakliusz Lipiec
2019-04-25 18:14         ` Wiles, Keith
     [not found]       ` <20190503102857.15812-1-herakliusz.lipiec@intel.com>
2019-05-03 10:28         ` [dpdk-stable] [PATCH v5 1/2] ipc: fix memory leak in sync request Herakliusz Lipiec
2019-05-03 10:28         ` [dpdk-stable] [PATCH v5 2/2] net/tap: fix ipc related memory leak Herakliusz Lipiec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c061f24-ab40-670d-0b7a-fe331ba8a3f2@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=herakliusz.lipiec@intel.com \
    --cc=jianfeng.tan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).