From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: em: use hw accelerated crc hash function for arm64
Date: Fri, 14 Oct 2016 11:02:40 +0530 [thread overview]
Message-ID: <9d618bd3-f397-7a32-178b-b3c2b241e2fd@nxp.com> (raw)
In-Reply-To: <20161013133644.GA8096@localhost.localdomain>
On 10/13/2016 7:06 PM, Jerin Jacob wrote:
> On Fri, Oct 14, 2016 at 12:17:05AM +0530, Hemant Agrawal wrote:
>> if machine level CRC extension are available, offload the
>> hash to machine provide functions e.g. armv8-a CRC extensions
>> support it
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> ---
>> examples/l3fwd/l3fwd_em.c | 24 ++++++++++++++----------
>> 1 file changed, 14 insertions(+), 10 deletions(-)
>>
>> diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c
>> index 89a68e6..d92d0aa 100644
>> --- a/examples/l3fwd/l3fwd_em.c
>> +++ b/examples/l3fwd/l3fwd_em.c
>> @@ -57,13 +57,17 @@
>>
>> #include "l3fwd.h"
>>
>> -#ifdef RTE_MACHINE_CPUFLAG_SSE4_2
>> +#if defined(RTE_MACHINE_CPUFLAG_SSE4_2) && defined(RTE_MACHINE_CPUFLAG_CRC32)
>
> The will evaluate as FALSE always.
>
> Please change to logical OR operation here. ie #if defined(RTE_MACHINE_CPUFLAG_SSE4_2) ||
> defined(RTE_MACHINE_CPUFLAG_CRC32)
>
Oops! Will fix it.
>> +#define EM_HASH_CRC 1
>> +#endif
>
next prev parent reply other threads:[~2016-10-14 5:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 14:54 [dpdk-dev] [PATCH] examples/l3fwd: em path hash offload to machine Hemant Agrawal
2016-08-23 14:54 ` [dpdk-dev] [PATCH] examples/l3fwd: enabling 4m hash for all 64 bit archs Hemant Agrawal
2016-10-13 8:22 ` Thomas Monjalon
2016-10-05 11:52 ` [dpdk-dev] [PATCH] examples/l3fwd: em path hash offload to machine Jerin Jacob
2016-10-07 7:06 ` Hemant Agrawal
2016-10-13 18:47 ` [dpdk-dev] [PATCH v2] examples/l3fwd: em: use hw accelerated crc hash function for arm64 Hemant Agrawal
2016-10-13 13:36 ` Jerin Jacob
2016-10-14 5:32 ` Hemant Agrawal [this message]
2016-10-14 11:10 ` [dpdk-dev] [PATCHv3] " Hemant Agrawal
2016-10-25 16:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d618bd3-f397-7a32-178b-b3c2b241e2fd@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).