From: fengchengwen <fengchengwen@huawei.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <thomas@monjalon.net>, Kevin Laatz <kevin.laatz@intel.com>,
<dev@dpdk.org>
Subject: Re: [PATCH] dmadev: add tracepoints
Date: Thu, 13 Apr 2023 11:44:38 +0800 [thread overview]
Message-ID: <9dbabadc-c2e6-1f5b-d7b3-d6b23b874c1d@huawei.com> (raw)
In-Reply-To: <ZDZ/cXrhDvT8w+8/@bricha3-MOBL.ger.corp.intel.com>
On 2023/4/12 17:52, Bruce Richardson wrote:
> On Wed, Apr 12, 2023 at 02:48:08AM +0000, Chengwen Feng wrote:
>> Add tracepoints at important APIs for tracing support.
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> ---
>> lib/dmadev/meson.build | 2 +-
>> lib/dmadev/rte_dmadev.c | 39 ++++++--
>> lib/dmadev/rte_dmadev.h | 56 ++++++++---
>> lib/dmadev/rte_dmadev_trace.h | 133 +++++++++++++++++++++++++++
>> lib/dmadev/rte_dmadev_trace_fp.h | 113 +++++++++++++++++++++++
>> lib/dmadev/rte_dmadev_trace_points.c | 59 ++++++++++++
>> lib/dmadev/version.map | 10 ++
>> 7 files changed, 391 insertions(+), 21 deletions(-)
>> create mode 100644 lib/dmadev/rte_dmadev_trace.h
>> create mode 100644 lib/dmadev/rte_dmadev_trace_fp.h
>> create mode 100644 lib/dmadev/rte_dmadev_trace_points.c
>>
> For completeness, do you have any numbers for the performance impact (if
> any) to the DMA dataplane APIs with this tracing added?
No, because:
The dataplane trace points was disable default (unless the RTE_ENABLE_TRACE_FP is set),
so there will no trace-points code default.
So I think it will not impact performance default.
>
> /Bruce
>
> .
>
next prev parent reply other threads:[~2023-04-13 3:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 2:48 Chengwen Feng
2023-04-12 9:52 ` Bruce Richardson
2023-04-13 3:44 ` fengchengwen [this message]
2023-04-13 8:45 ` Bruce Richardson
2023-04-12 11:00 ` Morten Brørup
2023-04-13 6:30 ` fengchengwen
2023-04-13 8:25 ` Morten Brørup
2023-04-15 0:33 ` [PATCH v3] " Chengwen Feng
2023-05-24 21:12 ` Thomas Monjalon
2023-05-27 0:17 ` fengchengwen
2023-05-26 8:42 ` [PATCH v4] " Chengwen Feng
2023-07-03 3:54 ` fengchengwen
2023-07-07 10:40 ` Thomas Monjalon
2023-07-09 3:23 ` fengchengwen
2023-07-10 6:49 ` Thomas Monjalon
2023-07-10 7:50 ` fengchengwen
2023-07-31 12:48 ` Thomas Monjalon
2023-08-03 7:52 ` fengchengwen
2023-08-14 14:16 ` Thomas Monjalon
2023-10-11 9:55 ` fengchengwen
2023-11-06 20:59 ` Thomas Monjalon
2023-11-07 1:26 ` fengchengwen
2024-01-12 10:38 ` fengchengwen
2023-10-20 2:21 ` [PATCH] dmadev: add tracepoints at control path APIs Chengwen Feng
2023-11-06 20:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbabadc-c2e6-1f5b-d7b3-d6b23b874c1d@huawei.com \
--to=fengchengwen@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).