From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>, dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/qos_sched: fix uninitialized scalar variable
Date: Mon, 23 Oct 2017 09:31:32 -0700 [thread overview]
Message-ID: <9dc9d7ef-f238-08cc-c970-819419185d90@intel.com> (raw)
In-Reply-To: <20171023103600.89883-1-jasvinder.singh@intel.com>
On 10/23/2017 3:36 AM, Jasvinder Singh wrote:
> Fix problem with uninitialized rx/tx deferred_start flags of the struct
> rte_eth_rxconf/txconf by initializing with 0 value (deferred start of
> the rx/tx queues is turned off). This setting allows device rx/tx
> queues to start with rte_eth_dev_start().
>
> CID 194999 (#1 of 1): Uninitialized scalar variable (UNINIT)
> CID 195009 (#1 of 1): Uninitialized scalar variable (UNINIT)
Is this Coverity ID? If so we have a defined format for it:
Coverity issue: xxxxxx
Fixes: yyyyyyyyyyyy ("..................")
Cc: stable@dpdk.org [if required]
Signed-off-by: .....
Thanks,
ferruh
>
> Fixes: de3cfa2c9823 ("sched: initial import")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> examples/qos_sched/init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
> index 004ac54..038f042 100644
> --- a/examples/qos_sched/init.c
> +++ b/examples/qos_sched/init.c
> @@ -118,6 +118,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)
> rx_conf.rx_thresh.wthresh = rx_thresh.wthresh;
> rx_conf.rx_free_thresh = 32;
> rx_conf.rx_drop_en = 0;
> + rx_conf.rx_deferred_start = 0;
>
> tx_conf.tx_thresh.pthresh = tx_thresh.pthresh;
> tx_conf.tx_thresh.hthresh = tx_thresh.hthresh;
> @@ -125,6 +126,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)
> tx_conf.tx_free_thresh = 0;
> tx_conf.tx_rs_thresh = 0;
> tx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS;
> + tx_conf.tx_deferred_start = 0;
>
> /* init port */
> RTE_LOG(INFO, APP, "Initializing port %"PRIu16"... ", portid);
>
next prev parent reply other threads:[~2017-10-23 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 10:36 Jasvinder Singh
2017-10-23 16:31 ` Ferruh Yigit [this message]
2017-10-24 8:41 ` Singh, Jasvinder
2017-10-24 9:09 ` Jasvinder Singh
2017-10-24 21:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc9d7ef-f238-08cc-c970-819419185d90@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).