From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>, yliu@fridaylinux.org
Cc: daniel.verkamp@intel.com, james.r.harris@intel.com,
pawelx.wodkowski@intel.com, dev@dpdk.org,
Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: add API for getting last_idx of vrings
Date: Wed, 28 Mar 2018 10:57:14 +0200 [thread overview]
Message-ID: <9e7643db-0736-1768-d4eb-972d926c7021@redhat.com> (raw)
In-Reply-To: <20180305155959.21212-1-tomaszx.kulasek@intel.com>
Hi Tomasz,
On 03/05/2018 04:59 PM, Tomasz Kulasek wrote:
> vhost-net devices might keep track of last descriptors indices by
> themselves, and assuming they initially start at 0, but that is not the
> case for vhost-scsi. Initial last descriptor indices are set via
> VHOST_USER_SET_VRING_BASE message, and we cannot possibly predict what
> will they be. Setting these to vqueue->used->idx is also not an option,
> because there might be some yet unprocessed requests between these and
> the actual last_idx. This patch adds API for getting/setting last
> descriptor indices of vrings, so that they can be synchronized between
> user-device and rte_vhost.
>
> The last_idx flow could be as following:
>
> * vhost start,
> * received SET_VRING_BASE msg, last_idx is set on rte_vhost side,
> * created user-device, last_idx pulled from rte_vhost,
> * requests are being processed by user-device, last_idx changes,
> * destroyed user-device, last_idx pushed to rte_vhost,
> * at this point, vrings could be recreated and another SET_VRING_BASE
> message could arrive, so last_idx would be set
> * recreated user-device, last_idx pulled from rte_vhost.
>
>
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> lib/librte_vhost/rte_vhost.h | 24 ++++++++++++++++++++++++
> lib/librte_vhost/vhost.c | 27 +++++++++++++++++++++++++++
> 2 files changed, 51 insertions(+)
>
I agree with the patch, but it is missing the declaration of the new API
in rte_vhost_version.map.
Thanks,
Maxime
next prev parent reply other threads:[~2018-03-28 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 15:59 Tomasz Kulasek
2018-03-28 8:57 ` Maxime Coquelin [this message]
2018-03-28 9:31 ` Kulasek, TomaszX
2018-04-19 14:57 ` Maxime Coquelin
2018-07-26 15:43 ` Thomas Monjalon
2018-07-26 19:11 ` Stojaczyk, DariuszX
2018-07-26 19:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e7643db-0736-1768-d4eb-972d926c7021@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=daniel.verkamp@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
--cc=pawelx.wodkowski@intel.com \
--cc=tomaszx.kulasek@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).