From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] ethdev: fix indirect action convert
Date: Wed, 31 May 2023 14:57:09 +0100 [thread overview]
Message-ID: <9e9a1834-a8ef-12b5-71e5-409ed7bffe76@amd.com> (raw)
In-Reply-To: <MW2PR12MB4666AC3C150831D5253427BAD64A9@MW2PR12MB4666.namprd12.prod.outlook.com>
On 5/29/2023 7:12 AM, Ori Kam wrote:
> Hi Suanming,
>
>> -----Original Message-----
>> From: Suanming Mou <suanmingm@nvidia.com>
>> Sent: Friday, May 26, 2023 6:18 AM
>>
>> As indirect action conf fills the indirect action handler, while
>> converting indirect action, the action conf(action handler) should
>> be copied from original indirect action conf instead of duplicating
>> the action handler memory.
>>
>> Fixes: 4b61b8774be9 ("ethdev: introduce indirect flow action")
>>
>> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
>> ---
>> lib/ethdev/rte_flow.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
>> index 69e6e749f7..ff740f19a4 100644
>> --- a/lib/ethdev/rte_flow.c
>> +++ b/lib/ethdev/rte_flow.c
>> @@ -889,7 +889,15 @@ rte_flow_conv_actions(struct rte_flow_action *dst,
>> src -= num;
>> dst -= num;
>> do {
>> - if (src->conf) {
>> + if (src->type == RTE_FLOW_ACTION_TYPE_INDIRECT) {
>> + /*
>> + * Indirect action conf fills the indirect action
>> + * handler. Copy the action handle directly instead
>> + * of duplicating the pointer memory.
>> + */
>> + if (size)
>> + dst->conf = src->conf;
>> + } else if (src->conf) {
>> off = RTE_ALIGN_CEIL(off, sizeof(double));
>> ret = rte_flow_conv_action_conf
>> ((void *)(data + off),
>> --
>> 2.25.1
>
> Acked-by: Ori Kam <orika@nvidia.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-05-31 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 3:18 Suanming Mou
2023-05-29 6:12 ` Ori Kam
2023-05-31 13:57 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e9a1834-a8ef-12b5-71e5-409ed7bffe76@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).