From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Eads, Gage" <gage.eads@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"alialnu@mellanox.com" <alialnu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
Date: Thu, 4 Apr 2019 16:13:40 +0100 [thread overview]
Message-ID: <9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com> (raw)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E54210E11@FMSMSX108.amr.corp.intel.com>
On 4/4/2019 3:14 PM, Eads, Gage wrote:
>
>> 04/04/2019 15:00, Thomas Monjalon:
>>> When enabling pedantic compilation with
>> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
>>> the compiler complains about non standard 128-bit integer type:
>>>
>>> include/rte_atomic_64.h:223:3: error:
>>> ISO C does not support ‘__int128’ types [-Werror=pedantic]
>>>
>>> It must be marked as an extension of the standard C language to be
>>> accepted in pedantic compilation.
>>>
>>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>
>> Forgot one line:
>>
>> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
>>
>> Note: It seems only Ferruh can reproduce it.
>> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
>>
>>
>
> With that change:
> Acked-by: Gage Eads <gage.eads@intel.com>
>
I confirm it fixes the build issue:
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2019-04-04 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 13:00 Thomas Monjalon
2019-04-04 13:00 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 14:14 ` Eads, Gage
2019-04-04 14:14 ` Eads, Gage
2019-04-04 15:13 ` Ferruh Yigit [this message]
2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:23 ` Thomas Monjalon
2019-04-04 15:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alialnu@mellanox.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).