From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix parsing
Date: Tue, 10 Apr 2018 11:40:32 +0200 [thread overview]
Message-ID: <9fdd3dea-8646-91c3-da29-46ba16aae136@redhat.com> (raw)
In-Reply-To: <20180409175740.86858-1-roy.fan.zhang@intel.com>
On 04/09/2018 07:57 PM, Fan Zhang wrote:
> Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application")
>
> This patch fixes the parsing of cryptodev id in the cmdline.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/vhost_crypto/main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index bc867240d..860200e29 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -95,11 +95,6 @@ parse_cryptodev_id(const char *q_arg)
>
> /* parse decimal string */
> pm = strtoul(q_arg, &end, 10);
> - if ((pm == '\0') || (end == NULL) || (*end != '\0')) {
> - RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg);
> - return -1;
> - }
> -
> if (pm > rte_cryptodev_count()) {
> RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg);
> return -1;
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
I'll squash it with faulty commit if not yet merged by Ferruh.
Thanks,
Maxime
next prev parent reply other threads:[~2018-04-10 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:34 [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Fan Zhang
2018-04-09 15:34 ` [dpdk-dev] [PATCH] lib/librte_vhost: remove packet dump Fan Zhang
2018-04-11 8:47 ` Maxime Coquelin
2018-04-11 8:59 ` Maxime Coquelin
2018-04-11 14:36 ` Maxime Coquelin
2018-04-09 15:45 ` [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Maxime Coquelin
2018-04-09 15:53 ` Maxime Coquelin
2018-04-09 16:38 ` [dpdk-dev] [PATCH v2] vhost/crypto: " Fan Zhang
2018-04-09 17:57 ` [dpdk-dev] [PATCH] examples/vhost_crypto: fix parsing Fan Zhang
2018-04-10 9:40 ` Maxime Coquelin [this message]
2018-04-09 18:01 ` [dpdk-dev] [PATCH] vhost/crypto: fix makefile Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin
2018-04-09 18:21 ` [dpdk-dev] [PATCH] vhost/crypto: fix session id printf Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin
2018-04-11 9:22 ` [dpdk-dev] [PATCH] vhost/crypto: fix incorrect formatting Fan Zhang
2018-04-11 9:56 ` Maxime Coquelin
2018-04-10 7:32 ` [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Wodkowski, PawelX
2018-04-10 7:43 ` Maxime Coquelin
2018-04-10 7:47 ` Wodkowski, PawelX
2018-04-10 7:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdd3dea-8646-91c3-da29-46ba16aae136@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).