DPDK patches and discussions
 help / color / mirror / Atom feed

From: Loc Nguyen <locnguyen@niometrics.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools: add device index for dpdk-devbind script
Date: Tue, 4 Jun 2019 21:35:51 +0800	[thread overview]
Message-ID: <A065B29F-692C-477D-B16B-D0A4517B5DE7@niometrics.com> (raw)
In-Reply-To: <20190604100141.GA1311@bricha3-MOBL.ger.corp.intel.com>

Hi Bruce,

Thanks for the feedback. In my application, we map the NIC interfaces into port numbers,
which are these indexes. For example, we have an config file saying we would like to use
port 2, 3 and 5 for RX. Having the indexes printed together with the NIC interfaces via this
script helps us to easily select the correct interfaces to use. Especially when we usually
bind or unbind the interfaces to kernel driver or DPDK driver depending on the situation,
which will cause a shift in the interface to port number mapping. On machines with more
than 10 interfaces, it’s much slower if we need to count the indexes manually.

Thanks,
Loc

> On 4 Jun 2019, at 6:01 PM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> On Mon, Jun 03, 2019 at 08:57:36PM +0800, Loc Nguyen wrote:
>> Add a device index in front of the PCI ID for easy counting
>> 
>> Network devices using DPDK-compatible driver
>> ============================================
>> 0: 0000:07:00.0 ...
>> 1: 0000:07:00.1 ...
>> 
>> Signed-off-by: Loc Nguyen <locnguyen@niometrics.com>
>> ---
>> usertools/dpdk-devbind.py | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
> While I don't see anything wrong with this change, can you elaborate on why
> you think this is of use? The rest of the script doesn't do anything with
> these indexes so why is it worth using columns of screen space to display
> them?
> 
> Thanks,
> /Bruce

next prev parent reply	other threads:[~2019-06-04 13:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 12:57 Loc Nguyen
2019-06-04 10:01 ` Bruce Richardson
2019-06-04 13:35   ` Loc Nguyen [this message]
2019-06-04 15:50 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A065B29F-692C-477D-B16B-D0A4517B5DE7@niometrics.com \
    --to=locnguyen@niometrics.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).