From: "Jain, Deepak K" <deepak.k.jain@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Griffin, John" <john.griffin@intel.com>
Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
Date: Fri, 13 May 2016 08:24:44 +0000 [thread overview]
Message-ID: <A09C9DDE180C7E429EC68E2BFB95C90339374036@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <1802357.As1ss59lSu@xps13>
Hi Thomas,
This change was made to fix the compilation issues arising when optimization flag was changed. Hence its related to same optimization flag patch.
Do you want us to separate the Makefile and .c file change?
Regards,
Deepak
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Friday, May 13, 2016 9:18 AM
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-10 10:24, Arek Kusztal:
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
>
> Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
There is another change below. Should it be a separate patch?
> --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> @@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
> * Write (the length of AAD) into bytes 16-19 of state2
> * in big-endian format. This field is 8 bytes
> */
> - *(uint32_t *)&(hash->sha.state1[
> + uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
> ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> - ICP_QAT_HW_GALOIS_H_SZ]) =
> - rte_bswap32(add_auth_data_length);
> + ICP_QAT_HW_GALOIS_H_SZ];
> +
> + *aad_len = rte_bswap32(add_auth_data_length);
> +
> proto = ICP_QAT_FW_LA_GCM_PROTO;
> } else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2) {
> proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
>
next prev parent reply other threads:[~2016-05-13 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:24 Arek Kusztal
2016-05-10 9:56 ` Jain, Deepak K
2016-05-13 8:17 ` Thomas Monjalon
2016-05-13 8:24 ` Jain, Deepak K [this message]
2016-05-31 11:29 ` De Lara Guarch, Pablo
2016-06-07 14:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A09C9DDE180C7E429EC68E2BFB95C90339374036@IRSMSX107.ger.corp.intel.com \
--to=deepak.k.jain@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).